Coder Social home page Coder Social logo

Comments (7)

bourdakos1 avatar bourdakos1 commented on May 18, 2024 1

Hi @mohsin, we just did a large refactor involving all the c++ namespaces, so this could be a regression. I’ll take a look and make sure it still builds on my M1 MacBook.

from nearby.

mohsin avatar mohsin commented on May 18, 2024 1

@bourdakos1 Yes, it is resolved. I did have to fork out and make one modification i.e. switch exclude-main to main as the exclude-main branch was missing on your fork. I also noticed that you added a Test for the same to the master branch of this repo but missed out merging cl/500537425 which is the main fix that the tests are meant for. Thanks again for a swift fix. Appreciate it!

from nearby.

bourdakos1 avatar bourdakos1 commented on May 18, 2024 1

The issue was with the abseil repo, so cl/500537425 was just a test pointing at a fork of abseil with the fix. However, the fix has been merged into the main branch of abseil so my fork was no longer necessary.

from nearby.

bourdakos1 avatar bourdakos1 commented on May 18, 2024

Yea, its failing for me with the same error. I'll look into what broke and why our tests are still passing.

from nearby.

mohsin avatar mohsin commented on May 18, 2024

Sure, thank you! Appreciate it.

from nearby.

bourdakos1 avatar bourdakos1 commented on May 18, 2024

Okay, I think I've fixed the issue. You can test by changing the nearby branch from master to cl/500537425

from nearby.

bourdakos1 avatar bourdakos1 commented on May 18, 2024

Fixed in #1189

from nearby.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.