Coder Social home page Coder Social logo

Comments (18)

evykassirer avatar evykassirer commented on May 18, 2024 1

Very much agreed! It should go in the README.

I'll try to get this done this weekend, or you could add it if you're interested :)

from mathsteps.

karuppiah7890 avatar karuppiah7890 commented on May 18, 2024 1

Okay! Let me help 😄

from mathsteps.

evykassirer avatar evykassirer commented on May 18, 2024 1

goodnight! 🌃

oo I was going to make a gitter for mathsteps! I'm so glad you suggested it too.

I'm thinking something very similar to the existing expression example in the README, just add one for equations

e.g. building on your example above

const mathsteps = require('.');

const steps = mathsteps.solveEquation('2x + 3x = 35');

console.log(steps);
steps.forEach(step => {
	// e.g. before change: 2x + 3x = 35
    console.log("before change: " + step.oldEquation.print());
    // e.g. change: SIMPLIFY_LEFT_SIDE
    console.log("change: " + step.changeType);
    // e.g. after change: 5x = 35
    console.log("after change: " + step.newEquation.print());
    // e.g. # of substeps: 2
    console.log("# of substeps: " + step.substeps.length);
});

what do you think?

from mathsteps.

evykassirer avatar evykassirer commented on May 18, 2024 1

eh, let's just close this issue, and have it part of the wiki issue instead.

yeah! I'm excited about the wiki 👍

from mathsteps.

evykassirer avatar evykassirer commented on May 18, 2024

(let me know if you want to do it and I'll leave it to you)

from mathsteps.

karuppiah7890 avatar karuppiah7890 commented on May 18, 2024

I am new to the repository. I need some guidance on this. And it's API documentation, I think people who created the API should do it, or help me do it. But the latter is kind of double work in this case, no ?

from mathsteps.

evykassirer avatar evykassirer commented on May 18, 2024

I don't mind double work if you're interested in working on it (always happy to support someone contributing to mathsteps!) but am also quite fine to do it on my own - just wanted to give you the option :)

from mathsteps.

karuppiah7890 avatar karuppiah7890 commented on May 18, 2024

We can discuss here or in gitter.im and I am in India, UTC+05:30 time zone.

from mathsteps.

karuppiah7890 avatar karuppiah7890 commented on May 18, 2024

It's night now, for me. We can discuss tomorrow!

from mathsteps.

karuppiah7890 avatar karuppiah7890 commented on May 18, 2024

Pretty neat code! @evykassirer 😄

from mathsteps.

karuppiah7890 avatar karuppiah7890 commented on May 18, 2024

Do add this one as an example for equations ! 😄 Just remove the console.log(steps) line since it puts up lots of clumsy values. The forEach function part shows em in a neat manner.

from mathsteps.

evykassirer avatar evykassirer commented on May 18, 2024

oh yes! I meant to take that line out oooops.

Do you want to make the pull request that adds this example?

from mathsteps.

karuppiah7890 avatar karuppiah7890 commented on May 18, 2024

Sure! 👍

from mathsteps.

karuppiah7890 avatar karuppiah7890 commented on May 18, 2024

I created a separate issue for the equation solving example. #102 And created a PR #103 for the same

from mathsteps.

evykassirer avatar evykassirer commented on May 18, 2024

great! would you like to see more thorough API docs too? or do you think the example you added gives enough information (which would mean we can close this issue)

from mathsteps.

karuppiah7890 avatar karuppiah7890 commented on May 18, 2024

I think a more thorough API documentation is needed since there are some more functionalities, like substeps that has some information same as steps. But it's not mentioned and we can't just assume that steps and substeps are of same type. So, it's good if we provide this and more info in the API docs. We can keep it small and simple!

from mathsteps.

evykassirer avatar evykassirer commented on May 18, 2024

sweet, I think it should go in the wiki #66

from mathsteps.

karuppiah7890 avatar karuppiah7890 commented on May 18, 2024

Cool, so shall we close this issue ? or just keep it open till we add docs Wiki ?

And woah, Wiki list has lots of stuff, it can help contributors to get familiar with the code base 👍 and contribute with more ease!

from mathsteps.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.