Coder Social home page Coder Social logo

Comments (11)

Raibaz avatar Raibaz commented on May 18, 2024 1

Nice one @emars :)

from mathsteps.

emars avatar emars commented on May 18, 2024

If this is a recurring issue, something like:

http://stackoverflow.com/a/41620850/2816843

could be implemented.

Having a preinstall check that verifies that the user is on the proper version of node.

from mathsteps.

evykassirer avatar evykassirer commented on May 18, 2024

oh, sweet!

that looks very helpful and I totally think we should add it, thanks :)

from mathsteps.

evykassirer avatar evykassirer commented on May 18, 2024

script done! thanks to @Raibaz and to @emars for the suggestion

from mathsteps.

evykassirer avatar evykassirer commented on May 18, 2024

there's an issue where if you npm install mathsteps there's an error Error: Cannot find module 'semver'

I don't have time to look into it now, but hopefully we can fix it soon.

@aelnaiem ?

from mathsteps.

Raibaz avatar Raibaz commented on May 18, 2024

I think this is because preinstall is run before dependencies are installed...perhaps moving npm run requirements-check to install or postinstall would fix it?

from mathsteps.

evykassirer avatar evykassirer commented on May 18, 2024

yeah I think that's the issue too.. it's odd because both the stackoverflow answer and medium post user preinstall but then dependencies aren't installed yet... 😛 so maybe they're wrong! They don't have many votes, so that's possible.

I'm also looking around to try to find ways to test installing it again without patching a new version. Let me know if you know of anything

from mathsteps.

aelnaiem avatar aelnaiem commented on May 18, 2024

It seems that node-semver should be installed with npm according to this:
https://docs.npmjs.com/files/package.json

But we still need to install it ourselves for this to work. Running it after the install seems to defeat the purpose. Going to continue looking into this

from mathsteps.

aelnaiem avatar aelnaiem commented on May 18, 2024

Enforcing the engine was deprecated as part of an effort to shift control from module authors to application authors. Curious if this suggests that the best practice is to just notify application authors of the node version requirement in the README, and they can also see the requirement in the package.json

from mathsteps.

evykassirer avatar evykassirer commented on May 18, 2024

Sounds OK to me - too bad though :(

from mathsteps.

evykassirer avatar evykassirer commented on May 18, 2024

should be fixed now :)

from mathsteps.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.