Comments (3)
The "issue" is here:
https://github.com/google/marzipano/blob/master/src/stages/Stage.js#L159
Stage.prototype.updateSize = function() {
this._width = this._domElement.parentElement.clientWidth;
this._height = this._domElement.parentElement.clientHeight;
this._updateSize(); // defined by subclasses
this.emit('resize');
this.emitRenderInvalid();
};
clientWidth
and clientHeight
always return 0 until they are part of a document.
I wonder if there's any way to circumvent this.
from marzipano.
Unfortunately, there's no API to set the stage size. I believe this is an oversight; it would be nice to support the off-page rendering case.
I think Stage#updateSize
should take an explicit width and height as arguments, and Stage#updateSize
should be the one reading the size from the DOM and passing it along. This way, regular clients wouldn't be forced to set the size explicitly, but your use case would be possible by instantiating the stage directly.
Pull request #36 gives the general idea. It's not ready to be merged yet - I need to fix some of the demos and test it more thoroughly.
from marzipano.
Thank you very much,
Came up with a similar solution, but I prefer yours and I'll incorporate it until Pull request #36 is ready.
Thanks for the help :)
from marzipano.
Related Issues (20)
- Is it possible to export from Marzipano Tool with high resolution?
- Info Hotspot Customization HOT 2
- Marzipano not working on safari and ios devices properly
- Image owner/permission for Angra do Heroismo panorama? HOT 1
- npm ERR! Error while executing: npm ERR! C:\Program Files\Git\cmd\git.EXE ls-remote
- Compass widget on viewer HOT 1
- How to use Marzipano HOT 2
- Image Url Source fromString explained HOT 2
- zoom out - change fov
- Double-click zoom
- How to use the renderComplete event ?
- Accessibility improvements
- How to determine if an image exists when using ImageUrlSource() ?
- relativ path to images/tiles ??
- How the yaw value is calculated? HOT 5
- The value of tile.z remains unchanged at 0.
- Crop Pano to Cube
- @tjgq Tiago Quelhas — is mazipano still being worked on?
- Change yaw parameter when click hotspot HOT 1
- Inquiry Regarding Trojan:Script/Wacatac.B!ml Detection in Downloaded Data
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from marzipano.