Coder Social home page Coder Social logo

Comments (3)

r3db avatar r3db commented on May 18, 2024

The "issue" is here:
https://github.com/google/marzipano/blob/master/src/stages/Stage.js#L159

Stage.prototype.updateSize = function() {
  this._width = this._domElement.parentElement.clientWidth;
  this._height = this._domElement.parentElement.clientHeight;

  this._updateSize(); // defined by subclasses

  this.emit('resize');
  this.emitRenderInvalid();
};

clientWidth and clientHeight always return 0 until they are part of a document.
I wonder if there's any way to circumvent this.

from marzipano.

tjgq avatar tjgq commented on May 18, 2024

Unfortunately, there's no API to set the stage size. I believe this is an oversight; it would be nice to support the off-page rendering case.

I think Stage#updateSize should take an explicit width and height as arguments, and Stage#updateSize should be the one reading the size from the DOM and passing it along. This way, regular clients wouldn't be forced to set the size explicitly, but your use case would be possible by instantiating the stage directly.

Pull request #36 gives the general idea. It's not ready to be merged yet - I need to fix some of the demos and test it more thoroughly.

from marzipano.

r3db avatar r3db commented on May 18, 2024

Thank you very much,
Came up with a similar solution, but I prefer yours and I'll incorporate it until Pull request #36 is ready.

Thanks for the help :)

from marzipano.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.