lovefield.min.js does not support aliases for aggregate fields... about lovefield

[freshp86]

Thanks for the report!

Given that @export annotation is used at

lovefield/lib/aggregated_column.js

Line 101 in 6e6cc7c

* @export

Closure compiler should preserve as() when minify-ing, but apparently this is not the case. Need to investigate further, and potentially build a minimal repro against the compiler.

[freshp86]

I am not able to reproduce the problem. Seems to work fine for me with lovefield.min.js. See complete example below.

var schemaBuilder = lf.schema.create('todo', 1);

schemaBuilder.createTable('Item').
    addColumn('id', lf.Type.INTEGER).
    addColumn('description', lf.Type.STRING).
    addColumn('deadline', lf.Type.DATE_TIME).
    addColumn('done', lf.Type.BOOLEAN).
    addPrimaryKey(['id']).
    addIndex('idxDeadline', ['deadline'], false, lf.Order.DESC);

var todoDb;
var item;

schemaBuilder.connect().then(function(db) {
  todoDb = db;
  item = db.getSchema().table('Item');
  var row = item.createRow({
    'id': 1,
    'description': 'Get a cup of coffee',
    'deadline': new Date(),
    'done': false
  });

  return db.insertOrReplace().into(item).values([row]).exec();
}).then(function() {
  return todoDb.select(
    lf.fn.count(item.id).as('count of rows')
  ).from(item).where(item.done.eq(false)).exec();
}).then(function(results) {
  console.log(JSON.stringify(results));
});

Which prints the following in the devtools console

[{"count of rows":1}]

Which version of Lovefield are you using? I tried both the master branch, as well the 2.1.12 and both work fine.

[johndimm]

You are correct!  The version that fails is the one in the codelab stock_analyzer.  The current minified version works.    (My bad.  Thought I had tested the current one but the old one must have been cached.) Bad version:  

…

-rw-r-----@ 1 johndimm  staff  116374 May 26  2015 lovefield.min.js $ wc -l lovefield.min.js      345 lovefield.min.js Good version:

-rw-r--r--  1 johndimm  staff  142677 Jul 17 10:28 lovefield.min.js.new $ wc -l lovefield.min.js.new      276 lovefield.min.js.new    On Friday, July 19, 2019, 12:40:02 PM PDT, freshp86 <[email protected]> wrote: I am not able to reproduce the problem. Seems to work fine for me with lovefield.min.js. See complete example below. var schemaBuilder = lf.schema.create('todo', 1); schemaBuilder.createTable('Item'). addColumn('id', lf.Type.INTEGER). addColumn('description', lf.Type.STRING). addColumn('deadline', lf.Type.DATE_TIME). addColumn('done', lf.Type.BOOLEAN). addPrimaryKey(['id']). addIndex('idxDeadline', ['deadline'], false, lf.Order.DESC); var todoDb; var item; schemaBuilder.connect().then(function(db) { todoDb = db; item = db.getSchema().table('Item'); var row = item.createRow({ 'id': 1, 'description': 'Get a cup of coffee', 'deadline': new Date(), 'done': false }); return db.insertOrReplace().into(item).values([row]).exec(); }).then(function() { return todoDb.select( lf.fn.count(item.id).as('count of rows') ).from(item).where(item.done.eq(false)).exec(); }).then(function(results) { console.log(JSON.stringify(results)); }); Which prints the following in the devtools console [{"count of rows":1}] Which version of Lovefield are you using? I tried both the master branch, as well the 2.1.12 and both work fine. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.