Coder Social home page Coder Social logo

Comments (2)

pav-kv avatar pav-kv commented on June 10, 2024 1

The proposed solution:

  • Factor out the loop of defining revisions into a separate background task.
  • Make it so that the RunBatch only reads the already defined batches from the database.
  • Limit max number of revisions that RunBatch can go through. Possibly even make it so that it only builds one at a time. This will make metrics/traces for RunBatch easier to analyze.
  • Possible optimization: channel the defined revisions from the batch defining task to the revision building task, to avoid the redundant database reads. This matches nicely with the one-batch-at-a-time idea (cancels out the cost of making a DB read for each revision).

from keytransparency.

gdbelvin avatar gdbelvin commented on June 10, 2024

if ApplyRevision is much slower than the incoming mutations flow then DefineRevision will keep returning longer and longer slices of revisions,. As a side effect of that, the corresponding RunBatch RPC trace will grow uncontrollably, etc.

MaxBatchSize should prevent the batch size from growing uncontrollably.

from keytransparency.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.