Default max volume is very low? about horologist

[laiyichin]

Hi, It looks like the VolumeUiState might not be emitting correctly and is using the default value. Can you inspect to see if volume state in your audioRepository?

horologist/media/audio-ui/src/main/java/com/google/android/horologist/audio/ui/VolumeUiState.kt

Line 24 in 29edb10

val max: Int = 1,

horologist/media/audio-ui/src/main/java/com/google/android/horologist/audio/ui/VolumeViewModel.kt

Lines 64 to 69 in 29edb10

	public val volumeUiState: StateFlow<VolumeUiState> =
	volumeRepository.volumeState.map(VolumeUiStateMapper::map).stateIn(
	scope = viewModelScope,
	started = SharingStarted.WhileSubscribed(5000),
	initialValue = VolumeUiState()
	)

Alternatively, luizgrp@ has a sample app that you can try cloning and running to see if the RSB volume change is working as expected?
https://github.com/luizgrp/HorologistSimpleMediaAppGuide

[zxzxwu]

volumeStates from audioRepository are reported correctly with max=15(and note that I am using com.google.android.horologist.audio.SystemAudioRepository), changes are also reflected.

[luizgrp]

For future reference, I could also reproduce the issue with the code from the simple media app guide using this repo after updating Horologist to 0.5.3 from 0.4.5. In 0.4.5 the issue was not present.

[yschimke]

Such a subtle bug, I reviewed it at the time, and even looking at the PR again just thought it was fine. But using the viewModel StateFlow doesn't trigger compose state tracking.