Coder Social home page Coder Social logo

Comments (2)

ofrobots avatar ofrobots commented on May 16, 2024

I'm unable to reproduce this on your plugin-types branch. You will have to do some initial investigation yourself and report back.

from gts.

kjin avatar kjin commented on May 16, 2024

The issue stems from me including generated git-ignored source files, which are being checked. I didn't realize that I had already fixed them locally, and CI kept failing because it was regenerating these source files.

This makes me think of two improvements we can make to avoid this problem (despite the questionable usage of generated source files in the linked PR, in general it's a use case we still want to support):

  • gts check and gts fix should show a list of files that clang-format takes issue with, if not the fixes that should be made/have been made themselves. I already talked about this in #60 as being a low-priority improvement but I now think this would be extremely useful.
  • We should not use the list of files generated by tslint for formatting (this is the current behavior). It seems like Linter.getFileList(Linter.createProgram('...')) gets a list of files in a source dependency graph, making its return value a longer list than the list of files matching the glob specified in tsconfig.json. This is useful for linting, but undesirable for formatting.

from gts.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.