Coder Social home page Coder Social logo

Comments (10)

jinwoo avatar jinwoo commented on May 22, 2024

Does it happen only when you explicitly pass the files?

from gts.

JustinBeckwith avatar JustinBeckwith commented on May 22, 2024

It seems to only happen when I pass arguments in the folder/*.ext format. Running gts check lib/discovery.ts works fine.

Same bug applies to fix.

from gts.

jinwoo avatar jinwoo commented on May 22, 2024

Are you on windows?

from gts.

JustinBeckwith avatar JustinBeckwith commented on May 22, 2024

lol no

from gts.

jinwoo avatar jinwoo commented on May 22, 2024

This sounds like the wildcard expansion doesn't happen from the shell. Let me take a look.

from gts.

jinwoo avatar jinwoo commented on May 22, 2024

Now I know why this happens. It's because the shell expansion for lib/*.ts also includes those *.d.ts files.

from gts.

jinwoo avatar jinwoo commented on May 22, 2024

I'm not sure what's the correct fix here. We could change so that

  1. gts ignores *.d.ts files
  2. Discourage people from using wildcards

Maybe 1 is better?

from gts.

JustinBeckwith avatar JustinBeckwith commented on May 22, 2024

Interesting! I'm pretty sure I've used tslint against d.ts files - why wouldn't that work?

from gts.

jinwoo avatar jinwoo commented on May 22, 2024

I'm not sure. In google-api-nodejs-client, the *.d.ts files are not recognized by the typescript server. My fix will be "Ignore files that are not recognized by the typescript server".

from gts.

JustinBeckwith avatar JustinBeckwith commented on May 22, 2024

Fixed by #87

from gts.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.