Comments (4)
This quick and dirty fix made it work for me on MacOS:
GTMAppAuth.patch
I guess the isMaxMacOSVersionGreaterThanTenOneFive
macro does not do what was intended here. I never saw the key in my queries, that got me thinking.
Also, according to Apple [1], passing accessibility
keys along to KeychainHelper
(like here) is only supported if kSecUseDataProtectionKeychain
is set to true
[1] Apple:
You can use this attribute for macOS keychain items only if you also set a value of true for the kSecUseDataProtectionKeychain key, the kSecAttrSynchronizable key, or both. For any item marked as synchronizable, the value for the kSecAttrAccessible key may only be one whose name does not end with ThisDeviceOnly, as those cannot sync to another device.
from gtmappauth.
Hi and thanks for the issue! Since you have a patch, would you mind sending up a pull request for us to take a look at?
from gtmappauth.
I have drafted #237 to address this. Still need to do some testing in the example apps and hope to write some unit tests around this issue as well.
from gtmappauth.
Some visual proof that this draft PR begins to address the issue.
from gtmappauth.
Related Issues (20)
- Server Client ID for Mac auth HOT 2
- Reference AppAuth in Package.swift HOT 3
- Update usage of deprecated methods HOT 1
- iOS example not working HOT 1
- GTMAppAuth(GTMAppAuthFetcherAuthorization.o) build failure HOT 1
- Issues with OIDExternalUserAgent when requesting OIDAuthState HOT 2
- leaving old webview prompt
- Is GTMAppAuth considered OAuth OOB flow? HOT 3
- Use modern archiving and unarchiving methods in GTMAppAuthFetcherAuthorization.swift HOT 3
- Add support for GTMSessionFetcher 2.x HOT 4
- `pod lib lint` fails for watchOS on `macOS-12` runner HOT 1
- Ensure that `@objc(the_name)` for `AuthState` works with the new `KeychainStore` HOT 1
- g
- Re-enable watchOS platform in test specs
- Link generated documentation in README
- how to use for tvOS
- Need of required reason API policy HOT 2
- V2 to V4 pod migration: GTMAppAuthFetcherAuthorization(fromKeychainForName:) replacement HOT 2
- Privacy Manifest for GTMAppAuth HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from gtmappauth.