Comments (6)
@cushon yep, #1075 clearly did the trick; I've verified it (and bumped in enola-dev/enola#579). Resolved! Tx.
from google-java-format.
It's theoretically possible to fully statically link native images, including libc, using musl: https://www.graalvm.org/22.0/reference-manual/native-image/StaticImages/
Another option is to do the build on a system with an older libc version (as suggested in oracle/graal#6183 (comment)), by downgrading the version of the image the release process is using, i.e. not using ubuntu-latest
.
Yet another option would be for github codespaces to support the same version of ubuntu as github actions 🤔
from google-java-format.
Yet another option would be for github codespaces to support the same version of ubuntu as github actions 🤔
But then this issue could still appear in other situations... I would suggest we look at this more like "it should just work" than "it should work in Codespaces which are based on Ubuntu vX" - WDYT?
Another option is to do the build on a system with an older libc version (as suggested in oracle/graal#6183 (comment)), by downgrading the version of the image the release process is using, i.e. not using ubuntu-latest.
The idea being that then it would work on most older and newer distros - because even newer distros would always also have all older versions of e.g. libc? Is that typically the case? (Honest question!)
It's theoretically possible to fully statically link native images, including libc, using musl: https://www.graalvm.org/22.0/reference-manual/native-image/StaticImages/
Isn't this the simplest? Any good reason why we would not want to do this? File Size? Do we care? (I don't.)
from google-java-format.
My understanding is that glibc is generally backwards compatible, so building against older versions and running against newer versions will work. So using a slightly older ubuntu image would be an easy way to make the image more compatible.
musl seems like an interesting option, and I'm not worried about optimizing for binary size either. It looks slightly more involved to set up, the graal instructions suggest downloading it and building it yourself. But if someone was interested in setting that up I'd be happy to review a PR for it :)
from google-java-format.
So using a slightly older Ubuntu image would be an easy way to make the image more compatible.
==> #1075
FTR: I'm not sure if this will actually do the trick. But it can't really hurt either, so let's?
Fully static would probably still be better - if someone knows the configuration, do contrib. a PR!
from google-java-format.
I have made a release that includes the change to use an older ubuntu image: https://github.com/google/google-java-format/releases/tag/v1.21.0
@vorburger can you check if that fixes the issue you were seeing?
from google-java-format.
Related Issues (20)
- Does not work in InteliJ client
- Unnamed pattern cannot be parsed
- The unused method cannot be detected HOT 2
- Import Ordering configuration suppressed on README HOT 2
- help HOT 4
- Version 1.20.0 hasn't been published to MavenCentral HOT 1
- 1.20.0 binaries reports incorrect version (HEAD-SNAPSHOT) when called with the -v flag HOT 2
- Request google-java-format IntelliJ plugin version 1.18 HOT 1
- Before commit reformatting option in IntelliJ does invoke plugin
- The google-java-formatter eclipse plugin doesn't change the format of my code HOT 2
- IllegalAccessError from com.sun.tools.javac.util
- Omit the redundant method isReal() to make it simpler
- Excess indentation with method-receiving text blocks HOT 2
- compatibility with Gradle 9.x
- Inconsistent blank line between license and package statement HOT 1
- Inconsistent formatting of text blocks in 1.21.0 HOT 7
- bug report: 1.21.0 IntelliJ vs jar inconsistency HOT 3
- Misleading message for --dry-run with --replace
- MAX_LINE_LENGTH parameterized HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from google-java-format.