Comments (12)
Hey, is this issue still open? If yes, can I work on this?
from data-transfer-project.
please assign it to me...
from data-transfer-project.
Hey, I noticed that most methods on the class depend on private method makeGetRequest
in order to mock it I would need to make it visible but I don't want to break encapsulation. I noticed there is also a makePostRequest
which is public and is used for mocked responses in GooglePhotosImporterTest
. If it's okay to change the access modifier on the method I can complete unittesting the methods dependent on makeGetRequest
.
from data-transfer-project.
Would package-private sufficient for the tests? If so, usually you could mark these methods package-private and annotate them with @VisibleForTesting
.
from data-transfer-project.
yes ok it works. currentlyt working on this
from data-transfer-project.
Hey ,sorry for the noob question, I can't find this info.
I'm trying to make a first commit with most of the test cases but I'm not able to push to origin, I'm trying git push -u origin test-importer-interface
and receiving 403 error with message remote: Permission to google/data-transfer-project.git denied to FilippoULIVO
I just submitted my CLA agrrement, but i'm not sure it's related to that. could you help?
wanted to make a first commits also to check if I could pass all the different style checks
from data-transfer-project.
I completed the test coverage for the class.
Btw @MewX as I was sayngmakePostRequest
is public, I didn't write test for it because I belive it should be made package-private just as the makeGetRequest
,having it public defeats the purpose of the interface, from IntelliJ I can see it's only used in tests as mock.
I would need some guidance on the Pull request process for submitting my contribute
from data-transfer-project.
I'm trying to make a first commit with most of the test cases but I'm not able to push to origin, I'm trying git push -u origin test-importer-interface and receiving 403 error with message remote: Permission to google/data-transfer-project.git denied to FilippoULIVO
I believe that's because you're accidentally trying to develop directly on this repo, but you instead want to maintain your branch on your own repo (both in draft state and when you're ready to open a PR for it). You can get your own repo by clicking the "fork" button (or visiting https://github.com/google/data-transfer-project/fork).
maybe-helpful guessing on my part here, but please read the docs and run at your own risk (backup your work, etc)
Since you already have a working copy of the repo in your terminal, you can tell that copy tell about your new fork by adding a new git "remote" like so:
$ git remote -v # pay attention to the output from this command; note how it will change later (you'll probably only have "origin" lines right now)...
$ git remote add fork [email protected]:FilippoULIVO/data-transfer-project.git
$ git remote -v # now "fork" should be listed to
I'm guessing there that you have SSH configured, but if not you may want to set-url
to HTTPS instead before running this command:
$ git push fork test-importer-interface
Once that's all done your branch "test-importer-interface" will be visible in the github UI under your account (from which a PR can be opened when you're ready)
from data-transfer-project.
Please review?
from data-transfer-project.
Hey, if this pull request is okay I'm happy to keep contributing to the project @jzacsh
from data-transfer-project.
sorry for the repeated trial and error. I don't understand if my pull request is well formulated or if I'm doing something wrong
from data-transfer-project.
hey @jzacsh @MewX is this issue still relevant? could you review my merge request please? thanks
from data-transfer-project.
Related Issues (20)
- Add ImportableItem interface to all data models HOT 3
- There is a vulnerability in Jena: 3.9.0,upgrade recommended
- `gradle test` is now failing with tons of IllegalArgumentException errors HOT 1
- unit tests not hermetic: actual network dns lookup appears to happen (and maybe more) for imgur
- one-off idempotent-ID computation is obsolete with newer DownloadableItem work
- Make size calculation mode more generic HOT 1
- techdebt: rm deprecated `IdempotentImportExecutorHelper` per #1107
- Remove dependency on jcenter HOT 2
- Add TransmogrificationConfig for Google importers HOT 2
- Fix code scanning alert - Use of RSA algorithm without OAEP HOT 1
- Requirements document HOT 2
- Is there any community forum/space? I want to join as developer/QA HOT 2
- import static org.datatransferproject.types.common.models.DataVertical.VIDEOS;
- import static org.datatransferproject.types.common.models.DataVertical.VIDEOS;
- Consolidate Google Photos third-party apis into a single interface
- Make the retrying methods API & adaptor agnostic
- Add YouTube handlers HOT 2
- Add vertical for health data and support common fitness platforms
- Sex free HD HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from data-transfer-project.