Coder Social home page Coder Social logo

Comments (3)

jonasfj avatar jonasfj commented on July 17, 2024 1

I think we did consider implementing the semantics from Cascade, but then it wouldn't be possible to return a custom 404 for a custom route, and have a different catch-all 404 for all routes.

For now consider using Cascade for mounts under api/.

I do see the problem, but this would be a breaking change, please have people vote up if they think this is desired behavior.

from dart-neats.

jonasfj avatar jonasfj commented on July 17, 2024

Let's introduce a sentinel final routeNotFound = shelf.Response.notFound('route not found');, and whenever a router has no matching route it returns the routeNotFound sentinel object.

Whenver a router gets a response from a handler or sub-router it will check if response is the sentinel (response == routeNotFound) if this is the case then the response is ignored and other routes are matched.

To do:

  • Add sentinel
  • Update documentation for router and example
  • Add tests
  • Update CHANGELOG.md explaining who default behavior for nested routers have changed, and why we chose not to make this a breaking change.

from dart-neats.

jonasfj avatar jonasfj commented on July 17, 2024

Fixed in shelf_router version 1.1.0.

from dart-neats.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.