Comments (11)
That makes more sense, but it doesn't explain why the code works. :-)
from closure-stylesheets.
i have a fork of closure-stylesheets
that gathers most, if not all, of these fixes and features introduced via PRs. i'll merge this in today, feel free to ping me if our fork can be helpful to you in the meantime before this gets merged to master
upstream.
from closure-stylesheets.
Any reason this wasn't merged yet? The problem still exists, and @Yannic's commit fixes it.
from closure-stylesheets.
@elipoultorak it does fix it but if memory serves, it just disables the input renaming map? or did it work for you? if so then yeah why isn't this merged lol
from closure-stylesheets.
TBH, I don't remember what problem I was trying to solve when I initially run into this crash, and I haven't seen it for the last two years.
IIRC, #125 worked but wasn't merged because the "fix" just hides the issue that the map isn't initialized where that's supposed to happen.
from closure-stylesheets.
I just tried it, and for some reason, it does rename it properly with the fix. I used a CLOSURE_COMPILED format instead of json, so I don't know if it would work with json. But when I use the master branch, or the last release, it gives me an error. When I use @Yannic's fork, it uses the correct renaming according to the map.
I know it sounds weird, do you know why it happens? Maybe the SubstitutionMap is initialised more than once, sometimes using a correct class, and sometimes not?
from closure-stylesheets.
Update: it also works with json maps.
from closure-stylesheets.
AFAIK, the crash above happens because the map isn't initialized at all. You're right that my fix works, but the map is only initialized right before the crash would happen and not where the initialization is supposed to happen.
Unfortunately, that's all I remember right now. If I remember to do so, I'll have a look (next week or so) if I can find some notes from two years ago.
from closure-stylesheets.
@elipoultorak @Yannic sick, ha ha
another one bites the dust, good work @Yannic
from closure-stylesheets.
Looks good, but is nobody at Google merging anything to this repo?
from closure-stylesheets.
@elipoultorak welcome to the gap between regular open source, and google internal :) lol
from closure-stylesheets.
Related Issues (20)
- incorrect error on nested @-rules HOT 2
- closure-stylesheets.jar missing? HOT 1
- Does not work with feature queries @supports
- Building closure stylesheets with Webpack
- box-decoration-break is an unrecognized property HOT 2
- Expand MergeAdjacentRulesetNodesWithSameDeclarations functionality to any repetitive rulesets
- Non splitting renaming type
- @supports throws "unknown @ rule" error
- Parsing error with css calc and negative number
- Parse error with calc()
- Unable to parse source maps
- RTL flipping does not handle transform, linear-gradient properties
- Can't parse grid layout css syntax using named grid lines
- List is missing 'all' property. Giving compile error.
- Escaped characters in css-identifier throws compiler parsing error
- How can i solve the GssParserException problem
- Dead project? HOT 2
- There is a vulnerability in Guava: Google Core Libraries for Java 20.0,upgrade recommended
- text-size-adjust is an unrecognized property
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from closure-stylesheets.