bazel build at/near head fails in multiple ways. about closure-library

[shicks]

@gkdn Is this something you're aware of? Can you speak to this at all?

[gkdn]

The problem here is the WORKSPACE definition in this repo is not accurate. However that file is only relevant for testing of the repo (which seems like lacking here). It is not used by the users of repo, they will actually have their own io_bazel_rules_closure definition so I guess that's why this issue wasn't visible outside.

Since there are no local tests, it is possible that some of the targets are miss configured for open-source. If nobody used those libs, they wouldn't be a way to know it other then tests. We only have limited coverage of the libs in rules_closure side.

Anyway, I will test the PR internally but I need a label for that; commented on it.

[bcsgh]

I'll grant that basically all users will have their own WORKSPACE, but at the same time I'd point out that a librarie's own WORKSPACE is de facto documentation of how to use it. I'd say that makes a repo having a fully working build (ideally with passing tests) into a "very nice to have" even if it's not 100% necessary.

Regardless: I'm glad to hear this is getting some attention.