jarjar failed handling org.xerial.snappy:snappy-java:1.1.8.2 about bazel-common

[jameslan]

Note that these two files are not in META-INF directory

[netdpb]

That part of the script merges files that appear in more than one JAR's META-INF directory by concatenating them, as long as you pass the right argument to the rule's merge_meta_inf_files parameter.

For some reason more than one of your JARs contains an org/xerial/snappy/VERSION file. What arguments are you passing to jarjar_library?

[jameslan]

merge_meta_info_files is for files under META-INF directory, right? But this duplicate detection applied to all files.

I don't have multiple jar containing org/xerial/snappy/VERSION, the org.xerial.snappy:snappy-java:1.1.8.2 itself contains org/xerial/snappy/VERSION and org/xerial/snappy/VERSION~, along with class files.

[jameslan]

Also, may I ask which command generates the file with tilde postfix? I tried the default zipper @bazel_tools//tools/zip:zipper, as well as unzip, to extract the same jar twice to the same location, but didn't find any file with tlide.

[netdpb]

The -B option passed to unzip here creates backup files.

We use this to prevent you from having a bug when two JARs contain the same file.

If org.xerial.snappy:snappy-java contains a VERSION~ file, that's likely a bug in their release. It looks like it was introduced in 1.1.7, since it's not there in 1.1.4.

I'm going to close this bug because I think the underlying problem is with snappy-java.