Instrumenting constructors fails with VerificationError when interacting with classes that lack stack map frames about allocation-instrumenter

[jhmanson]

Yeah, I think that was just a mistake - we do the right thing in the AllocationInstrumenter class. I'll push a fix. Thanks for reporting it.

[kyle-cackett]

Minimal reproducible example can be found here: https://github.com/kyle-cackett/class-instrumentation

[kyle-cackett]

@jhmanson do you have an idea of when you think this fix will be pushed? This issue is keeping us from moving to Java 8 so we're trying to decide whether to wait for a fix upstream or fork the library and apply the patch below:

a/src/main/java/com/google/monitoring/runtime/instrumentation/ConstructorInstrumenter.java b/src/main/java/com/google/monitoring/runtime/instrumentation/ConstructorInstrumenter.java
index 933d4c4..e53ed5a 100644
--- a/src/main/java/com/google/monitoring/runtime/instrumentation/ConstructorInstrumenter.java
+++ b/src/main/java/com/google/monitoring/runtime/instrumentation/ConstructorInstrumenter.java
@@ -116,7 +116,7 @@ public class ConstructorInstrumenter implements ClassFileTransformer {
   public static byte[] instrument(byte[] originalBytes, Class<?> classBeingRedefined) {
     try {
       ClassReader cr = new ClassReader(originalBytes);
-      ClassWriter cw = new ClassWriter(cr, ClassWriter.COMPUTE_MAXS);
+      ClassWriter cw = new ClassWriter(cr, ClassWriter.COMPUTE_FRAMES);
       VerifyingClassAdapter vcw = new VerifyingClassAdapter(cw, originalBytes, cr.getClassName());
       ClassVisitor adapter = new ConstructorClassAdapter(vcw, classBeingRedefined);

[jhmanson]

Sorry about that. I pushed the patch internally, and then my machine died, so it fell off my radar. I can push it tomorrow morning.

[jhmanson]

All done!

[kyle-cackett]

Thank you!

[kyle-cackett]

@jhmanson Do you have any plans for an upcoming release which will contain this fix? We'd like to depend on an official version if possible.

[jhmanson]

Hm... I think I don't have the right permissions to release to sonatype etc. Maybe @cushon or @cgdecker can help?

[kyle-cackett]

@cushon @cgdecker Do you have a sense for when we might expect a new release of the allocation instrumenter containing this fix?

[cgdecker]

Sorry for the long delay... I've released java-allocation-instrumenter 3.3.0 to Maven Central with this fix.