Comments (16)
Hm. Do you have any thoughts why LoadingViewCircle is not accessible when using as a Framework?
Ok, I will re-think naming.
from dgelasticpulltorefresh.
That's how it is in Swift. Internal classes are internal to a framework. Just make the classes and it's base class public. Also all initializers and overriden methods.
from dgelasticpulltorefresh.
The extension has to be public too.
from dgelasticpulltorefresh.
Basically make all my classes, extension and etc:
public class..
public extension..
public struct..
Right?
from dgelasticpulltorefresh.
Yes
from dgelasticpulltorefresh.
Was about to report the same issue with Cocoapods.
Thanks in advance for fixing this!
from dgelasticpulltorefresh.
Will make all public tonight and will push it
from dgelasticpulltorefresh.
Any update on this? I would love to use it in a project.
from dgelasticpulltorefresh.
Have a look at my latest commit on cocoapods branch: https://github.com/gontovnik/DGElasticPullToRefresh/tree/cocoapods
Is it enough for CocoaPods?
from dgelasticpulltorefresh.
You need to make the default initializer public as well:
DGElasticPullToRefreshLoadingViewCircle:
65: init() {
from dgelasticpulltorefresh.
What about extension methods such as:
func dg_addPullToRefreshWithActionHandler...?
from dgelasticpulltorefresh.
Might as well make it public. No harm in this case.
On 24 Oct 2015, at 20:43, Danil Gontovnik [email protected] wrote:
What about extension methods such as:
func dg_addPullToRefreshWithActionHandler...?—
Reply to this email directly or view it on GitHub.
from dgelasticpulltorefresh.
I guess now should be fine? :) If yes then I gonna merge it back to master and update cocoapods
from dgelasticpulltorefresh.
Seems to work. Looks like the extension functions don't need to be public as long as the extension itself is public. But no harm in making them public.
Have to say that this is the most coolest looking pull to refresh control I have seen so far. Keep up the good work!
from dgelasticpulltorefresh.
Looks like all files were not recompiled in my computer and there are still some problems. In the DGElasticPullToRefreshLoadingViewCircle class the init needs override keyword and setPullProgress, startAnimating and stopLoading need to be public as the overriden functions are public.
init(frame: .zero) does not compile. I think init() without frame should work as the base class already calls UIView's init with a zero frame.
from dgelasticpulltorefresh.
Released version 1.0.2, check it out, now all should be public. Please let me know if something does not work for you.
from dgelasticpulltorefresh.
Related Issues (20)
- Can it support external connection?
- The elastic effect getting stuck with a whole or half loading circle when async data. HOT 2
- Any plan to iOS 8.0 supported ?
- 1 pixel line between refresh view and collection view HOT 3
- Carthage support
- Add pull to load more? HOT 1
- Issue in multi-section tables
- iOS 11 Crash
- On iOS 11 this library doesn't work anymore. HOT 4
- Swift 4 support HOT 7
- objective c
- Everything is fine!
- Loading view moves down and a normal iOS Activity indicator is visible. HOT 1
- change datasource in the middle of pull
- Pull effect error HOT 1
- UITableView flicker HOT 3
- Swift 4.2 support HOT 1
- iOS 10.3.3 Crash! HOT 1
- Cocoapods import will report an error
- Wrong position of the pullToRefreshView HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from dgelasticpulltorefresh.