Flag using a package name as a variable name about lint

[dsymonds]

Golint is for style checking, and this isn't so much a style problem as a correctness problem. I think this belongs in govet (if anywhere); you could file a feature request for that at http://golang.org/issue/new.

[thejerf]

Are you aware that it is perfectly legal Go to shadow a package with a variable? It is a style matter. It "works" perfectly, and it is not a violation of the standard. It's just a bad idea. The error message I show you is what happens when you get bitten by the bad idea, not what happens when you merely shadow the variable.

If you are, then OK, cool. Just checking.

[dsymonds]

I know it's legal Go, but so is fmt.Printf("missing arg for %d"). Govet is
for things that are legal Go (i.e. stuff that compiles and runs, but is
incorrect); golint is for things that are correct, but not consistent with
the standard Go coding style.

Perhaps this falls in between somewhat, though I'll note that govet already
checks for some forms of shadowing, so it seems like it belongs on that
side of the fence.

[thejerf]

Righty-o, thanks!