Comments (2)
I assume you mean UnknownPublicKeyAlgorithm
rather than UnknownSignatureAlgorithm
?
Verifying a leaf certificate with an unknown public key algorithm doesn't seem that bizarre to me (though it's certainly not useful in the WebPKI), and removing support would probably break someone. Are there any justifications for this besides #66166? CertPool.Add
could just check for UnknownPublicKeyAlgorithm
itself, right?
from go.
I assume you mean UnknownPublicKeyAlgorithm rather than UnknownSignatureAlgorithm?
🤦, yes.
Verifying a leaf certificate with an unknown public key algorithm doesn't seem that bizarre to me (though it's certainly not useful in the WebPKI), and removing support would probably break someone. Are there any justifications for this besides #66166? CertPool.Add could just check for UnknownPublicKeyAlgorithm itself, right?
For roots and intermediates I think the argument is clearer, since we cannot reasonably build any chains with them, but I think you can make an equally compelling argument (although perhaps slightly less strong) argument for leaves, in that the certificate itself may be verified, but what is the certificate then to be used for? It cannot be used for TLS, since you need to verify the signature during the handshake, you can't use it for code signing, or S/MIME, because you would need to verify the signature, etc etc.
While I don't think this is extremely high priority, I think since we do explicitly target web PKI, and since isValid is only used during chain building, doing this lets us remove a little complexity that needs to be considered currently (#65390 is an example of how this has bitten us recently).
from go.
Related Issues (20)
- crypto/tls: panic with `crypto/tls/fipsonly` HOT 2
- proposal: x/sys/unix: add `STATX_MNT_ID_UNIQUE` mask value HOT 1
- cgocall(asmstdcallAddr, unsafe.Pointer(c)) Segmentation fault HOT 1
- strings: TrimLeft() returns unexpected value HOT 1
- x/net/webdav: PUT with missing intermediate collection gave 404, MUST be 409 [RFC4918:S9.7.1]) HOT 1
- net/http,x/crypto/ssh: Hijack hangs when underlying net.Conn doesn't support SetReadDeadline
- encoding/json: adding a MarshalJSON method confuses JSON marshalling HOT 4
- x/pkgsite: package removal request for https://pkg.go.dev/github.com/RectangelHelp/blockaid-client-go HOT 1
- x/tools/gopls: crash during internal/imports.scanDirForPackage (crash) HOT 2
- x/tools/gopls: "View package documentation": use type information
- x/tools/gopls: make Hover display std version information HOT 1
- cmd/compile: SIGBUS unaligned access on mips64 via qemu-mips64 HOT 7
- proposal: x/tools/go/types/typeutil: add TypeMap[V] HOT 14
- x/net/ipv4: TestRawConnReadWriteUnicastICMP failures HOT 1
- x/pkgsite: package removal request for https://pkg.go.dev/github.com/spywiree/languagecodes HOT 1
- cmd/compile: SIGBUS unaligned access on mips64 via qemu-mips64 [1.21 backport] HOT 6
- x/build: modify contents of "gray box" (summary markdown) in LUCI UI to be more directly to the point for test failures HOT 2
- x/net/http2/h2c panic HOT 2
- Reflect package for protobuf values HOT 4
- Proposal #43947 was accepted and implemented for this instead.
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from go.