Coder Social home page Coder Social logo

Comments (13)

gouguoyin avatar gouguoyin commented on June 1, 2024

Thank you for your feedback, I will seriously consider it.

from carbon.

tanqiangyes avatar tanqiangyes commented on June 1, 2024

If you need help, I'd be happy to provide it.

from carbon.

tanqiangyes avatar tanqiangyes commented on June 1, 2024

If you don't want to change the name, then perhaps the notes should be written more clearly? Because as it stands now, the notes don't describe what the functions do very clearly.

from carbon.

gouguoyin avatar gouguoyin commented on June 1, 2024

I also hesitated when I first named it, CreateFromDate is to be consistent with CreateFromTime, in CreateFromTime, the year, month, and day are taken from current time, so, all omitted values are taken to the current time.

from carbon.

gouguoyin avatar gouguoyin commented on June 1, 2024

Yesterday and Tomorrow have the same logic,hours, minutes and seconds are taken from the current time.

from carbon.

gouguoyin avatar gouguoyin commented on June 1, 2024

2023-01-01 Current Hour: Current Minutes: Current Seconds Current Nanoseconds? No Current Nanoseconds
image

from carbon.

gouguoyin avatar gouguoyin commented on June 1, 2024

Currently can use the following methods
carbon.CreateFromDate(2023,1,1).StartOfDay() // 2023-01-01 00:00:00

from carbon.

tanqiangyes avatar tanqiangyes commented on June 1, 2024

I know that I can also use carbon.CreateFromDateTimeNano. But the confusing nature of function names is still there.

from carbon.

tanqiangyes avatar tanqiangyes commented on June 1, 2024

image
Nanoseconds exist in your concrete realization.

2023-01-01 Current Hour: Current Minutes: Current Seconds Current Nanoseconds? No Current Nanoseconds image

from carbon.

gouguoyin avatar gouguoyin commented on June 1, 2024

What should be the year, month and day in CreateFromTime? 0000-00-00 or currentYear-currentMonth-currentDay

from carbon.

tanqiangyes avatar tanqiangyes commented on June 1, 2024

What should be the year, month and day in CreateFromTime? 0000-00-00 or currentYear-currentMonth-currentDay

currentYear-currentMonth-currentDay maybe this, but nobody can kown this from func name or func comment

from carbon.

tanqiangyes avatar tanqiangyes commented on June 1, 2024

What should be the year, month and day in CreateFromTime? 0000-00-00 or currentYear-currentMonth-currentDay

As you said, is it 0000-00-00 or currentYear-currentMonth-currentDay which is unknown to the user?

from carbon.

gouguoyin avatar gouguoyin commented on June 1, 2024

Optimized in v2.3.0
image

from carbon.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.