Coder Social home page Coder Social logo

Comments (4)

rShetty avatar rShetty commented on July 17, 2024

@btamadio Thanks for pointing this out. Can you raise a PR for the same, will have a look

from heimdall.

btamadio avatar btamadio commented on July 17, 2024

Here's a snippet illustrating the issue. With min=1second, max=8 seconds, and exp. factor=2,
I would expect the backoff times to be 1, 2, 4, 8, 8 seconds:

func main() {
	fmt.Println("testing constant backoff ...")
	s := httptest.NewServer(http.HandlerFunc(func(w http.ResponseWriter, _ *http.Request) {
		w.WriteHeader(500)
	}))
	defer s.Close()
	cli := httpclient.NewClient(
		httpclient.WithRetryCount(5),
		httpclient.WithHTTPClient(s.Client()),
		httpclient.WithRetrier(
			heimdall.NewRetrier(
				heimdall.NewExponentialBackoff(
					1*time.Second,
					8*time.Second,
					2,
					2*time.Millisecond,
				),
			),
		),
	)
	cli.AddPlugin(plugins.NewRequestLogger(os.Stdout, os.Stderr))
	_, _ = cli.Get(s.URL, nil)
}

Timestamps show this is not happening:

21/May/2020 11:18:37 GET http://127.0.0.1:51397 500 [0ms]
21/May/2020 11:18:37 GET http://127.0.0.1:51397 500 [0ms]
21/May/2020 11:18:38 GET http://127.0.0.1:51397 500 [0ms]
21/May/2020 11:18:39 GET http://127.0.0.1:51397 500 [0ms]
21/May/2020 11:18:40 GET http://127.0.0.1:51397 500 [1ms]
21/May/2020 11:18:41 GET http://127.0.0.1:51397 500 [0ms]

from heimdall.

rShetty avatar rShetty commented on July 17, 2024

@btamadio Thanks for the PR. Have added a few comments

from heimdall.

btamadio avatar btamadio commented on July 17, 2024

@btamadio Thanks for the PR. Have added a few comments

Took a look but couldn't find any comments on the PR.

from heimdall.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.