Comments (6)
Why not default to time.Duration
?. Let the client deal with conversion and passing the correct type.
from heimdall.
@kgrz I am not clear on this. What do you have in mind ?
from heimdall.
@rShetty Something like this: master...kgrz:pass-duration-to-client
My main point was to make this the default, instead of switching between int
and time.Duration
based on the config object. This will avoid the library dictating how the config should look like and keeps it simple.
from heimdall.
👍 Agree
from heimdall.
@kgrz Wanna raise a PR on this ? I think you already did the required change ?
from heimdall.
This is fixed in #13
from heimdall.
Related Issues (20)
- HystrixTimeout vs HTTPTimeout HOT 3
- No way to parse proxies / http transport with hystrix client? HOT 1
- How can I set verify=false when call to HTTPS endpoint? HOT 2
- Support single connection for multiple request HOT 3
- Add singleflight in client
- 'httpclient' forcing close connection
- Sending data-urlencode in Get request
- Dependency of gojek is pointing to gojektech HOT 1
- unable to install? HOT 3
- Gaps of "idle?" time when using a retrier extend the response time of my app HOT 1
- Requests are being hardcoded to get close after response HOT 1
- Unclear documentation for hystrix client options HOT 1
- One extra sleep at the end of the retry loop in client.Do func
- hystrix POST with retry returns "http: ContentLength=... with Body length 0"
- feat: Support for fallbacks with context
- httpclient.Do forces closes connection
- How to integrate elasticsearch APM HOT 1
- data race in hystrix client HOT 1
- client.Do() panics when passed in invalid character for url
- Hystrix http client - Unit missing in configuration HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from heimdall.