Coder Social home page Coder Social logo

Comments (2)

tvendelin avatar tvendelin commented on May 21, 2024 1

Hi there, and thanks for quick response!

I'm just trying to make my theme "standard-compliant". I think you might be a tick more explicit about what makes a theme to pass into submission stage.

You could, for instance, add a page to a project to test against the installation defaults. It shouldn't then contain any elements that require non-default configuration to work properly. This would be a useful indicator. For instance, I've discovered that tables without styling look ugly and fixed it.

Then, you might say: now run a server with this config, and see how your theme performs with <abbr>, <mark>, etc.

So, is it then OK to invite user to recursively clone a project repository that includes my theme as a git submodule?

from hugobasicexample.

digitalcraftsman avatar digitalcraftsman commented on May 21, 2024

Hello Toomas,

based on your question I assume you're asking prior of a theme submussion to www.github.com/gohugoio/hugoThemes, right? It might help to know a bit more about the context of your question, i.e. what you're trying to do.

The hugoBasicExample is used in place of the exampleSite directory for theme demos on www.themes.gohugo.io if the latter one is not provided. The setup in this repository meant to be minimal while covering a wide range of themes as possible.

My theme relies on pygmentsUseClasses = true et al. The test project doesn't, and so inline styling is applied. As a result, the appearance is a bit ugly. Is it acceptable to instruct the user to configure the project accordingly?

This repo isn't a static framework and can't cover all corner cases, especially when themes require a custom setup or configuration. Of course it is acceptable to let users configure the project according to your instructions. Pygments is likely configured the way it is because most of the users might use Hugo's built-in syntax highlighter Chroma nowadays.


In case you're planning to submit a new theme it's also possible submit a config file in the exampleSite directory to tweak a theme demo. In case your theme is more complex custom content can be used as well to cirumvent issues arising due to limitations of the hugoBasicExample.

from hugobasicexample.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.