Fork/pull request public repostories about gogs

[fuxiaohei]

Test comment

[v9n]

@unknwon Does anyone work on this issue?

[unknwon]

We're discussing this in the dev group.

[eryx]

+1
Eagerly waiting for this feature

[jijinggang]

+1
It's important feature

[stevenleeg]

⭐

Super excited for this!

[aarongreenlee]

+1

[btilford]

+1

[laurentdinclaux]

+1

[tubia]

• 1

[nandak522]

👍

[unknwon]

Update: master branch just pushed fork feature, PR is on the way!

[eryx]

👍

[bradleypeabody]

+1 This (pull requests) would help adoption as well, since it's a key feature when you start dealing with a team of more than just a couple of people.

[unknwon]

@bradleypeabody you're absolutely right!

[hugochinchilla]

+1 for pull requests

I have to choose between gitlab and gogs for managing repos at a company, if pull requests are going to be added soon gogs will be the winner.

[unknwon]

@hugochinchilla we're working on PR right now, should be released in near future. But GitLab obviously has more features than Gogs at current stage, make the best choice is important, your option.

[wangkuiyi]

+1 for Pull Request, so could we hope to replace Gitorious currently used in LinkedIn. Gitorious Merge Request feature sucks.

[Techcable]

+1 for Pull Request
Needed to migrate private repos to gogs

[sbditto85]

+1 for Pull Requests

Awesome job btw!

[disassembler]

+1 for Pull Requests! Really looking forward to trying this once this functionality is added!

[michaeldyrynda]

+1 for pull requests. We're using organisations / teams in the interim.

[Nothing4You]

👍 PRs

[rojaro]

+1

[izolate]

Eagerly waiting PRs. Thanks @unknwon

[kageurufu]

👍 for sure

[Xe]

Is there any update on this feature?

[unknwon]

@Xe it's WIP, but recently we've received big PRs, so currently work on PRs, will get back when finish reviewing.

[Xe]

Can you post the code as is in a feature branch? I'd be happy to help test and fix it.

[unknwon]

@Xe We appreciate that! 👊 But we would like to fully on our own for the initial version 😄

[xaionaro]

+1 for Pull Requests

[hasufell]

Yeah, very important feature. Pretty much the last thing missing before I remove gitlab from my server in favor of gogs.

+1 and keep up the good work

[dubcanada]

+1

I upvote for Pull Requests as well!

[bkleef]

Can't wait to enjoy this feature!

[bergwerf]

+1

[matrixik]

One question:
It is planed more like GitHub pull requests or do you plan to create something better? For example why Go team go with Gerrit (source: http://www.infoq.com/news/2014/11/golang-goes-git-github ):

As mentioned, a Google-hosted instance of Gerrit will be used for code reviews. In a separate discussion (https://news.ycombinator.com/item?id=8605242) about the use of Gerrit, Andrew Gerrand, Google Go engineer, explained that Gerrit has several advantages over GitHub's code review tool:

• In GitHub, merging pull requests causes pollution in the change history. "Gerrit will automatically rebase the changes atop the master branch head, leaving a nice linear history."
• GitHub forces contributors to create a public fork of the repository, if they do not have write access to it.
• Gerrit allows to collect many comments on a single pull requests, then just sending a single email.
• Gerrit supports multiple 'patch sets' for a particular change, which are particularly useful when reviewing large changes.

Personally I would love to see rebasing instead of merge commit (some background http://blog.spreedly.com/author/ntalbott/#.VGVhz5PF_Zs ).

Some more sites worth checking for improvements ideas (they exists on top of GitHub PR to fix it annoyances):
https://reviewable.io/
http://www.review.ninja/

[matrixik]

Phabricator.org and it code review part compared to Gerrit:
https://www.quora.com/Has-anyone-done-a-Gerrit-and-Phabricator-review

[hasufell]

Personally I would love to see rebasing instead of merge commit

The important part about pull requests (IMO) is not that you can merge them via the web UI, but that you can do review/comments and get automatic mail notification etc. I would never do tasks like merging, rebasing or even committing in a web interface.

Also, if gogs would be more like gerrit, I would probably not use it, because gerrit is not simple and enforces a particular workflow on you.

[unknwon]

Hi @matrixik , @hasufell , thanks for discussion!

For the initial purpose, Gogs would the pretty much the way GitHub does, but will open APIs/Webhooks to all of its actions as well. So that would be easier for people to integrate with any other services, and let Gerrit keep doing their good job.

[hickscorp]

+1, really waiting for PRs!

[mkmik]

+1

[nubbel]

+1

[bastiao]

I tested already the branch that says feature/pull-request but I did not see any button in the UI yet. Can you give us a status?

Thanks!

[thomasfedb]

✨

[unknwon]

@bastiao Thanks for asking.

True reason is we don't want to be harry on such a important feature, but we're working on it. And feature itself isn't standalone, there are related things we need to work on at the same time. So, hmm, thanks for the patient.

[geshan]

+1 probably the only thing blocking people from adopting gogs

[StrangeWill]

+1, though work around is to just do it the old-school way.

[jbrodriguez]

+1, thanks for your efforts @unknwon.

This was the feature most asked for in an article that was reposted on HackerNews and Reddit

[Techcable]

Github should add an upvote feature, my inbox is being spammed.

[tubia]

I totally agree with you @Techcable :)

[liminspace]

+1 for Pull Requests

[stroborobo]

Can we help somehow to make this happen faster? Don't forget, we're probably 95% devs here, too :)

[bastiao]

@Knorkebrot one of the problem is that @unknwon is not accepting most part of the PR. There are quite a lot pending.

[xaionaro]

@bastiao, disagree. There's almost no open PRs for such popular project. And all of them are quite fresh (the latest is "Mar 21").

[bastiao]

@xaionaro maybe I'm wrong then. If I can contribute some how, I'll be glad to help on that.

[matt-h]

@unknwon is away from gogs right now. He hasn't said why or for how long, but I'm guessing it is either Family, School, or Work taking all of his time at the moment. I'm sure when he gets back he'll review the existing pull requests so keep making them if you have something to fix/add.

[csu]

+1

Would also be great to get forking/pull requests on private repositories.

[SlowFourierTransform]

+1

Having pull requests and being able to review team members' code would be really helpful.

[galoppa]

If only anybody were working on this feature... :/
I like gogs better than gitlab, but I think I'll switch to gitlab because this project looks dead and no longer maintained

[bkleef]

@unknwon could you give us a short update on this?

[galoppa]

@bartvankleef Somebody has finally forked it and I think they are working on both pull requests and wikis https://github.com/go-gitea/gitea

[liuyang1]

+1, It's really good of gogs's easy deployment feature. But I need "Pull Request" feature. Without that, cannot use gogs in a large team.

[bastiao]

any news? :)

[unknwon]

@bastiao almost :)

[unknwon]

OK, well. Hi all!

It's now able to test Pull Request on https://try.gogs.io/ . To keep your data safe and clean for future releases, please blow up it and post feedback here now! 😉

[bastiao]

@unknwon you're doing great!

[xaionaro]

A huge thanks!

[xaionaro]

P.S.: IMHO, PR's should be in separate tab (Pull Requests, not Issues). However this's anyway great :)

[unknwon]

Thank you for following up! @bastiao @xaionaro

@ALL: It's in very early stage, so... be nice... 👀

P.S.: IMHO, PR's should be in separate tab (Pull Requests, not Issues). However this's anyway great :)

Yes, it will be added soon. I'm working on it.

[bastiao]

I'm updating my own installation and will test it properly. I will happy to return feedback too.

PS and offtopic: you should talk with people that fork gogs. It is not good to community to have disperse forks around. They was working on PR/forks too.

[bastiao]

# github.com/gogits/gogs/routers/api/v1
routers/api/v1/repo.go:105: opt.Gitignore undefined (type gogs.CreateRepoOption has no field or method Gitignore)
routers/api/v1/repo_hooks.go:29: unknown gogs.Hook field 'Id' in struct literal
routers/api/v1/repo_hooks.go:105: unknown gogs.Hook field 'Id' in struct literal
routers/api/v1/user.go:21: unknown gogs.User field 'Id' in struct literal

any idea why?

[unknwon]

@bastiao

go get -u github.com/gogits/go-gogs-client

and then rebuild

[bastiao]

@unknwon great, thanks!

[pcsch]

When opening a pull request the original repo gets a new open issue that is closed after merging.
This works for the issue view but in the overview for the original repo there is still one issue too much shown to be open. I think after mergin (which closes the "PR issue") the number of open issues should be decreased by one again.

e.g.:
When you had 10 open issues before the PR, you have 11 open after the PR, 10 open after merge but the overview still shows 11

(This was tested on try.gogs.io)

BTW: Thanks a lot for this feature.

[bastiao]

@unknwon the PR does not work inside the same repository. Only in forks?
I mean, it is useful in different branches of same repository.

[unknwon]

@bastiao right now, yes, only between forks(in same repo in the design though)

I think after mergin (which closes the "PR issue") the number of open issues should be decreased by one again.

@mexthemax good catch! Forgot that...

[Depado]

A friend of mine juste told me "Too bad it doesn't handle PRs". Went here. Saw the comment one hour ago saying it's now in test. Epic timing ! 💃

[ALenfant]

I am the friend in question. I've wanted to switch to Gogs for so long but I needed PR support. I'm so happy, thanks guys! :D

[unknwon]

@ALenfant hah, 😝

Note it's still early stage and may not as perfect as you expected. But I'm here to fix problems. 👀

[zarezadeh]

A bug here: https://try.gogs.io/swordwinter/prtest/pulls there is two pull requests, one open and one closed. But when you click on open PR, it will show the close one. It seems both of them got same id

[unknwon]

Thanks @zarezadeh ! I've pushed fix to try.gogs.io , and have fixed the index for your PR on the server :)

[zarezadeh]

Wow, that was fast, thanks.

[vijairaj]

This looks great! Waiting for this to get in to master.

[bastiao]

If you can allow support of pull requests in the same project, between branches, it will be great!

[unknwon]

OK, close right now.

Will open new issues for other specific needs.

[unknwon]

Important update

I've pushed code to develop branch and https://try.gogs.io that check if pull request has conflict with upstream every time fork repository or upstream repository is pushed, so conflict will be detected correspondingly right now.

Leave feedback here so I can help with further problems you may encounter! 🍻