Comments (7)
From awalterschulze on November 10, 2014 22:47:17
Sounds like a good feature, I like it :)
Since gogoprotobuf is a fork of goprotobuf, which is maintained by the go
authors, let us first make sure that they are not planning to fix this.
I think they should also care whether their code lints, but I have been
wrong before.
I just don't want to add another extension if they are planning to fix this
anyway.
Would you mind posting an issue on goprotobuf and pasting the link here, so
I can subscribe.
from protobuf.
From [email protected] on November 10, 2014 23:51:28
https://code.google.com/p/goprotobuf/issues/detail?id=59
from protobuf.
From awalterschulze on November 11, 2014 00:06:54
Ha ha, like I said I have been wrong before :)
I think this will be a good feature to add.
Status: Accepted
Labels: -Type-Defect Type-Enhancement
from protobuf.
From [email protected] on November 11, 2014 00:32:53
Sweet! Thanks for the quick follow-up. :)
from protobuf.
golint has a lot of suggestions for gogoprotobuf.
I don't know if it is really worth it to pursue golint ability.
Or why with all these other errors would you only want this one golint change?
gogoprotobuf already go vets, which I think is much more worth while.
Here follows a very small summary or the errors I saw:
receiver name should be a reflection of its identity; don't use generic names such as "me", "this", or "self"
exported method ... should have comment or be unexported
type Uuid should be UUID
func NewPopulatedUuid should be NewPopulatedUUID
package comment should not have leading space
don't use underscores in Go names; struct field XXX_unrecognized should be XXXUnrecognized
don't use underscores in Go names; const TheTestEnum_A should be TheTestEnumA
struct field Id should be ID
func GetId should be GetID
exported function NewAFromFace should have comment or be unexported
func name will be used as group.GroupDescription by other packages, and that stutters; consider calling this Description
type name will be used as moredefaults.MoreDefaultsB by other packages, and that stutters; consider calling this B
type MyJson should be MyJSON
func NewPopulatedMyJson should be NewPopulatedMyJSON
package comment should be of the form "Package enumstringer ..."
exported func NewEnumStringer returns unexported type *enumstringer.enumstringer, which can be annoying to use
from protobuf.
Generated files don't need to pass golint. I agree with you that it's not worth it. Not really sure what I was thinking :)
from protobuf.
I initially also thought this was a great idea.
Unfortunately its just too much work for too little reward.
from protobuf.
Related Issues (20)
- License question
- protoreflect
- Vulnerability?
- Panic: invalid Go type HOT 3
- github.com/gogo/protobuf is not installed
- Improper Input Validation in GoGo Protobuf HOT 1
- string time and duration
- oom
- Panic: reflect: Elem of invalid type HOT 1
- How to customize the name of an enumeration value, using the extension `enumvalue_customname ` seems unable to complete.
- m argument not work
- Call command.Generate(req *plugin.CodeGeneratorRequest) twice could cause bug.
- BUG: protoc-gen-gogofast not generate trailing comments
- How to generate parameter "description" in message of proto3 HOT 1
- proto: protect field access with lock to avoid possible data race
- proto: protect field access with lock to avoid possible data race
- Release v1.3.3 - Please please please create it pointing to v1.3.2
- Unsafe type assertion
- Generate a custom function. HOT 1
- [BUG] Variable name conflict if that both exists two fields named `id` and `getId`
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from protobuf.