Option to expose proto enum constants with proper Go style about protobuf

[awalterschulze]

From awalterschulze on November 10, 2014 22:47:17

Sounds like a good feature, I like it :)

Since gogoprotobuf is a fork of goprotobuf, which is maintained by the go
authors, let us first make sure that they are not planning to fix this.
I think they should also care whether their code lints, but I have been
wrong before.
I just don't want to add another extension if they are planning to fix this
anyway.

Would you mind posting an issue on goprotobuf and pasting the link here, so
I can subscribe.

[awalterschulze]

From [email protected] on November 10, 2014 23:51:28

https://code.google.com/p/goprotobuf/issues/detail?id=59

[awalterschulze]

From awalterschulze on November 11, 2014 00:06:54

Ha ha, like I said I have been wrong before :)

I think this will be a good feature to add.

Status: Accepted
Labels: -Type-Defect Type-Enhancement

[awalterschulze]

From [email protected] on November 11, 2014 00:32:53

Sweet! Thanks for the quick follow-up. :)

[awalterschulze]

golint has a lot of suggestions for gogoprotobuf.
I don't know if it is really worth it to pursue golint ability.
Or why with all these other errors would you only want this one golint change?

gogoprotobuf already go vets, which I think is much more worth while.

Here follows a very small summary or the errors I saw:

receiver name should be a reflection of its identity; don't use generic names such as "me", "this", or "self"

exported method ... should have comment or be unexported

type Uuid should be UUID

func NewPopulatedUuid should be NewPopulatedUUID

package comment should not have leading space

don't use underscores in Go names; struct field XXX_unrecognized should be XXXUnrecognized

don't use underscores in Go names; const TheTestEnum_A should be TheTestEnumA

struct field Id should be ID

func GetId should be GetID

exported function NewAFromFace should have comment or be unexported

func name will be used as group.GroupDescription by other packages, and that stutters; consider calling this Description

type name will be used as moredefaults.MoreDefaultsB by other packages, and that stutters; consider calling this B

type MyJson should be MyJSON

func NewPopulatedMyJson should be NewPopulatedMyJSON

package comment should be of the form "Package enumstringer ..."

exported func NewEnumStringer returns unexported type *enumstringer.enumstringer, which can be annoying to use

[andybons]

Generated files don't need to pass golint. I agree with you that it's not worth it. Not really sure what I was thinking :)

[awalterschulze]

I initially also thought this was a great idea.
Unfortunately its just too much work for too little reward.