Comments (4)
From awalterschulze on October 31, 2013 23:56:49
gogoprototests are done.
Making default values illegal for non-nullable fields might fix all my issues. https://code.google.com/p/gogoprotobuf/source/detail?r=321219d70bc26ad10c2ada5d148ea122473f4ac3 I should also make sure fieldpath works with defaults.
from protobuf.
From awalterschulze on November 01, 2013 00:04:31
I reverted changes which will make default and nullable work together https://code.google.com/p/gogoprotobuf/source/detail?r=53f1868722b1474411bf22f1cc69cd4a3b73f0b6 I see potential problems when unmarshalMerge comes around and and the default values override the already set values.
With non-nullable fields it is "hard" to tell if they have been set before.
I finally understand this
"Project Member #5 [email protected]:
Protocol buffers specify that it is possible to distinguish between a
field being set and a field having its default value, as bizarre as
that may seem. Thus a plain value is not sufficient representation,
and we decided that pointers were the least of the possible evils.
" - https://code.google.com/p/goprotobuf/issues/detail?id=29&can=1 I would rather not make nullable more popular than it needs to be.
So if it means that nullable has limited use cases this is good thing.
from protobuf.
From awalterschulze on November 01, 2013 00:58:42
This eliminated all of the problems I could see, except fieldpath https://code.google.com/p/gogoprotobuf/source/detail?r=96cc1417d78d7a5e57fa659342fe9d6332761e0b
from protobuf.
From awalterschulze on November 01, 2013 06:22:20
https://code.google.com/p/gogoprotobuf/source/detail?r=a2cbb9e3ce8ab9e350516a3cda5da7b61f926853 Finally fixed
Status: Fixed
from protobuf.
Related Issues (20)
- protoreflect
- Vulnerability?
- Panic: invalid Go type HOT 3
- github.com/gogo/protobuf is not installed
- Improper Input Validation in GoGo Protobuf HOT 1
- string time and duration
- oom
- Panic: reflect: Elem of invalid type HOT 1
- How to customize the name of an enumeration value, using the extension `enumvalue_customname ` seems unable to complete.
- m argument not work
- Call command.Generate(req *plugin.CodeGeneratorRequest) twice could cause bug.
- BUG: protoc-gen-gogofast not generate trailing comments
- How to generate parameter "description" in message of proto3 HOT 1
- proto: protect field access with lock to avoid possible data race
- proto: protect field access with lock to avoid possible data race
- Release v1.3.3 - Please please please create it pointing to v1.3.2
- Unsafe type assertion
- Generate a custom function. HOT 1
- [BUG] Variable name conflict if that both exists two fields named `id` and `getId`
- Possible deref after null
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from protobuf.