Comments (6)
Apparently, code search rate limits behave like primary rate limits (i.e., the response is a primary rate limit error),
but their reset time is really short (1min).
That means that when adding support for primary rate limit, it also needs to support sleep by default for short periods.
@NorseGaud @abhijit-hota - I haven't forgotten about this issue and I'm planning to do it soon. My days are pretty busy now, and I'm finishing off async-pagination support now, and then I'm gonna address this one.
https://github.com/gofri/go-github-pagination
from go-github-ratelimit.
@Sawthis
I wish.
I'm really over my head with work and my other duties. Haven't forgotten about it, and I hope that I'll be able to make the first step next week
Edit: not sure if you heard the news about Iran attacking israel, but there might be some more delay after all 😅
from go-github-ratelimit.
bump :)
from go-github-ratelimit.
@NorseGaud nice to see interest. I'd love to hear more about your use case (and hopefully, I'll get to it soon)
from go-github-ratelimit.
Following the discussion in #9 - will be implemented using x-ratelimit-resource (and perhaps a fallback for endpoint-based heuristics, because x-ratelimit-resource isn't officially documented).
Will probably go into v2.0.0 to allow a clearer API, including:
- Renaming the options to be clearer on secondary vs primary rate limit.
- Support for returning a dedicated error instead of sleeping (probably different error type for secondary/primary -- keeping sleep the default for secondary, and return error as the default for primary).
- WithXXX for the options of injected (instead of the lazy approach of single options struct used now).
from go-github-ratelimit.
@gofri any update on this topic?
from go-github-ratelimit.
Related Issues (7)
- Add fallback for x-rateliimt-reset HOT 1
- Callback function doesn't trigger after secondary rate limit is hit HOT 9
- Handle Callback without waiting/reattempting? HOT 3
- Secondary Rate Limit detector misses message HOT 5
- Secondary rate limits are missed because documentation URL is changed HOT 4
- Multiple transports for Github App? HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from go-github-ratelimit.