Coder Social home page Coder Social logo

Comments (6)

elite-benni avatar elite-benni commented on July 17, 2024

Didn't you get the prompt when adding checkbox, if you want to add icon primitive too?

from spartan.

oidre avatar oidre commented on July 17, 2024

Didn't you get the prompt when adding checkbox, if you want to add icon primitive too?

No, i didn't get any prompt

maybe the issue can resolve with adding @spartan-ng/ui-icon-helm as peerdependences here?
peerdep

from spartan.

elite-benni avatar elite-benni commented on July 17, 2024

Ok, this is already fixed, I guess it is just not published yet.

Sorry, I could have provided a workaround in the first place.
You can add the icon with the same command as the other primitives
ng g @spartan-ng/cli:ui icon for CLI
npx nx g @spartan-ng/cli:ui icon for nx

You can always run ng g @spartan-ng/cli:ui and choose the primitives you need.

from spartan.

oidre avatar oidre commented on July 17, 2024

Ok, this is already fixed, I guess it is just not published yet.

Sorry, I could have provided a workaround in the first place. You can add the icon with the same command as the other primitives ng g @spartan-ng/cli:ui icon for CLI npx nx g @spartan-ng/cli:ui icon for nx

You can always run ng g @spartan-ng/cli:ui and choose the primitives you need.

i have installed the icon manually, but the primitive checkbox still appears
terms

i think it's because NgStyle is not applied when the component published
ngstyle

from spartan.

elite-benni avatar elite-benni commented on July 17, 2024

Where do you see this ng Style?

Acutally this this also an old bug, we planned to release the newest versions of the components soon.
The old version of the brn-checkbox used sr-only by mistake, this was changed to ngStyle wich is probably not released by now.
If you work with Tailwind, as temporary workaround you can add the following to the tailwind.config.js
safelist: ['sr-only'],

Sorry for the confusion.

from spartan.

goetzrobin avatar goetzrobin commented on July 17, 2024

New versions were just released @oidre! This should fix this issue! Please reopen if you still run into an issue

from spartan.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.