Comments (3)
This issue is tied to the use of setClassToCustomElement
. It probably also affects sheet
, dialog
and alert-dialog
from spartan.
yes you are right. i will check all cases where the setClassToCustomElement
is used. I edited the issue.
Thanks homj for pointing that issue out in the first place! ;)
from spartan.
Actually i do not understand the setClassToCustomElement
in the overlay components of alert
, sheet
and dialog
If i want to provide my customclasses for overlay, why should I use hlm anyway? ;)
the only purpose is to set it to the brn-dialog.component
via setOverlayClass which brn does.
This is an unresolvable problem, as the classes on the overlay componet are a completely different thing than settings the overlay classes in the brn-dialog
. The user would expect to set the overlay classes, wich now happens, but also the classes are added to the overlay component.
I would either just leave it as is, or delete the setClassToCustomElement completely from these two hlm Components.
Maybe it is not even worth the time, making such a great deal out of that, because no one will ever use hlm with custom overlay classes. ;)
from spartan.
Related Issues (20)
- hlmSelect does not have an invalid state style HOT 9
- Module Not recognize HOT 2
- Select does not work with number 0 and ngModel
- Brn and Hlm Error Directive for Form Fields HOT 1
- feat(data-table): Column Resize HOT 2
- RFC: Copy and paste brn files aswell
- RFC: Add breadcrumb component
- bug: select doesn't recognize changes if the initial value and the first change is the same
- Include music UI example at examples page
- RFC: Add Filter functionality for Listbox component HOT 2
- feat(data-table): dynamic table
- Not installing in angular 17 HOT 1
- RFC: Expose outputs closed and opened for brnMenuTriggerFor directive HOT 1
- Where would you like to create your workspace - question missing from Installation guide HOT 3
- Checkboxes within a scrollarea
- Tooltip covers other Elements after hiding
- using aria-describedby is causing a blank line at the end of the page
- NG0311: Directive CdkMenuTrigger does not have an input with a public name of brnMenuTriggerFor. HOT 2
- Error: No matching export for "DynamicViewModule" in @ngneat/overview package
- Data Table: Table height does't update when size options change
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from spartan.