Coder Social home page Coder Social logo

Comments (3)

homj avatar homj commented on July 17, 2024 1

This issue is tied to the use of setClassToCustomElement. It probably also affects sheet, dialog and alert-dialog

from spartan.

elite-benni avatar elite-benni commented on July 17, 2024 1

yes you are right. i will check all cases where the setClassToCustomElement is used. I edited the issue.
Thanks homj for pointing that issue out in the first place! ;)

from spartan.

elite-benni avatar elite-benni commented on July 17, 2024

Actually i do not understand the setClassToCustomElement in the overlay components of alert, sheetand dialog
If i want to provide my customclasses for overlay, why should I use hlm anyway? ;)

the only purpose is to set it to the brn-dialog.component via setOverlayClass which brn does.

This is an unresolvable problem, as the classes on the overlay componet are a completely different thing than settings the overlay classes in the brn-dialog . The user would expect to set the overlay classes, wich now happens, but also the classes are added to the overlay component.

I would either just leave it as is, or delete the setClassToCustomElement completely from these two hlm Components.
Maybe it is not even worth the time, making such a great deal out of that, because no one will ever use hlm with custom overlay classes. ;)

from spartan.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.