Coder Social home page Coder Social logo

RFC: Avatar about spartan HOT 5 CLOSED

goetzrobin avatar goetzrobin commented on August 16, 2024
RFC: Avatar

from spartan.

Comments (5)

benjaminforras avatar benjaminforras commented on August 16, 2024 2

For the AvatarFallback I'd suggest to use structural directives like *brnAvatarFallback and inject it to the DOM whenever it's needed.

from spartan.

goetzrobin avatar goetzrobin commented on August 16, 2024 1

I'd say directives. That way people can also compose it if they wanted to. Maybe the avatar is also a button? Just gives you more flexibility IMO

from spartan.

goetzrobin avatar goetzrobin commented on August 16, 2024

Love it! I would argue that the delay and switching is the brn part and the hlm part is the styling of making the avatar round, etc. If you look at the radix CSS example you get a good idea of the separation of concerns

from spartan.

mihajm avatar mihajm commented on August 16, 2024

Ah, completely missed that, alright makes perfect sense. Do you prefer the directive or component approach? :)

from spartan.

mihajm avatar mihajm commented on August 16, 2024

Would make the impl. a bit prettier since we can just ngIf="canDisplayImage; else fallbackTemplate" it :) Are there any other benefits I'm not seeing?

from spartan.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.