Comments (5)
For the AvatarFallback I'd suggest to use structural directives like *brnAvatarFallback
and inject it to the DOM whenever it's needed.
from spartan.
I'd say directives. That way people can also compose it if they wanted to. Maybe the avatar is also a button? Just gives you more flexibility IMO
from spartan.
Love it! I would argue that the delay and switching is the brn part and the hlm part is the styling of making the avatar round, etc. If you look at the radix CSS example you get a good idea of the separation of concerns
from spartan.
Ah, completely missed that, alright makes perfect sense. Do you prefer the directive or component approach? :)
from spartan.
Would make the impl. a bit prettier since we can just ngIf="canDisplayImage; else fallbackTemplate" it :) Are there any other benefits I'm not seeing?
from spartan.
Related Issues (20)
- RFC: Advanced pagination
- RFC: Radio Groups as card layouts HOT 9
- Docs: API reference for all components
- Renaming the generated `hlm-` selector to anything else breaks the `select` component HOT 10
- Popover overflowing past screen when trigger is on the edge of the screen HOT 3
- Add the multi select component
- Peer dependencies causing problem - multiple versions of ui-core HOT 3
- ERROR RuntimeError: NG0203: inject() must be called from an injection context such as a constructor
- ERROR ReferenceError: window is not defined HOT 1
- [nitro] [request error] [unhandled] [GET] "/trpc/note.list,note.list
- Error: Error: Cannot find module tslib ... code: 'ERR_MODULE_NOT_FOUND'
- (node:77788) [DEP0155] DeprecationWarning: Use of deprecated trailing slash pattern
- Dropdown does not lock page scroll HOT 6
- Select: Initial Value is not set when options are provided vie @for
- Adding the hlmMenuItem directive on dropdown separated in multiple components throw an exception HOT 1
- unable to install nx-workspace with presets HOT 2
- hlmSelect does not have an invalid state style HOT 9
- Module Not recognize HOT 2
- Select does not work with number 0 and ngModel
- Brn and Hlm Error Directive for Form Fields HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from spartan.