Comments (7)
Yes, that is what I'm suggesting.
Keep the existing functionality but add a way to simply pass in a string and call it a day (like matTooltip
does it)
from spartan.
We are taking this approach to mimic the RadixUI behavior. Personally, I also prefer it because it let's me avoid having an ng-template
with a ref to it, which I pass to the tooltip. I am open to supporting both, but want to keep the hlm-tooltip for now to stay consistent with this approach we used in other components.
from spartan.
@alexciesielski maybe we can support both? I'd like to keep the template way to support something like adding a button. But I also see that it's a lot easier to simply pass in a string and call it a day
from spartan.
So can I go ahead with this? Or will it end up like the table PR? 😅
from spartan.
No you can go ahead and add this. Still owe you a review/decision with that. Haven't had much toke to spend on spartan lately, unfortunately.
from spartan.
Would you have anything against renaming hlmTooltipTrigger
to just hlmTooltip
? Similar to matTooltip
?
It looks weird to me to pass a string to the trigger, and it would be aligned with how Material does it, too.
from spartan.
Also I'm not sure if we even need to wrap the whole thing inside a hlm-tooltip
component for when using a TemplateRef
? It should be possible to just pass it into the directive and have it handle everything? Or is there something I am missing for what the wrapping component does?
My proposal would be to just have a single brn/hlmTooltip
directive, that takes both a string
and a TemplateRef
and renders them, without having to wrap the whole thing in another hlm-tooltip
component.
from spartan.
Related Issues (20)
- [nitro] [request error] [unhandled] [GET] "/trpc/note.list,note.list
- Error: Error: Cannot find module tslib ... code: 'ERR_MODULE_NOT_FOUND'
- (node:77788) [DEP0155] DeprecationWarning: Use of deprecated trailing slash pattern
- Dropdown does not lock page scroll HOT 6
- Select: Initial Value is not set when options are provided vie @for
- Adding the hlmMenuItem directive on dropdown separated in multiple components throw an exception HOT 1
- unable to install nx-workspace with presets HOT 2
- hlmSelect does not have an invalid state style HOT 9
- Module Not recognize HOT 2
- Select does not work with number 0 and ngModel
- Brn and Hlm Error Directive for Form Fields HOT 1
- feat(data-table): Column Resize HOT 2
- RFC: Copy and paste brn files aswell
- RFC: Add breadcrumb component
- bug: select doesn't recognize changes if the initial value and the first change is the same
- Include music UI example at examples page
- RFC: Add Filter functionality for Listbox component HOT 2
- feat(data-table): dynamic table
- Not installing in angular 17 HOT 1
- RFC: Expose outputs closed and opened for brnMenuTriggerFor directive HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from spartan.