Comments (4)
Thanks for all your efforts and catching that! This should be run as part of the lintstaged hook as defined the .lintstagedrc file.
Seems like some slipped through the cracks... we can run prettier on all and see if the issue pops up again.
from spartan.
I think we can close this one since newer PRs will always go through commit lint & prettier in the CI process. The commit hook also seems to be in place so the issues we saw earlier were probably before prettier was added to the CI action.
from spartan.
@goetzrobin I can look into setting this up over this weekend if this sounds reasonable. Please let me know your thoughts on this.
from spartan.
Should I run prettier in my existing PR then? Even if it modifies files outside my scope of changes? The CI flagged my PR correctly to not have formatting done.
from spartan.
Related Issues (20)
- ERROR RuntimeError: NG0203: inject() must be called from an injection context such as a constructor
- ERROR ReferenceError: window is not defined HOT 1
- [nitro] [request error] [unhandled] [GET] "/trpc/note.list,note.list
- Error: Error: Cannot find module tslib ... code: 'ERR_MODULE_NOT_FOUND'
- (node:77788) [DEP0155] DeprecationWarning: Use of deprecated trailing slash pattern
- Dropdown does not lock page scroll HOT 6
- Select: Initial Value is not set when options are provided vie @for
- Adding the hlmMenuItem directive on dropdown separated in multiple components throw an exception HOT 1
- unable to install nx-workspace with presets HOT 2
- hlmSelect does not have an invalid state style HOT 9
- Module Not recognize HOT 2
- Select does not work with number 0 and ngModel
- Brn and Hlm Error Directive for Form Fields HOT 1
- feat(data-table): Column Resize HOT 2
- RFC: Copy and paste brn files aswell
- RFC: Add breadcrumb component
- bug: select doesn't recognize changes if the initial value and the first change is the same
- Include music UI example at examples page
- RFC: Add Filter functionality for Listbox component HOT 2
- feat(data-table): dynamic table
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from spartan.