ansible_connection in secret paths about hashivault_vars

[easybe]

Cool, I quickly tested your branch and it works for me, thanks.

Still, maybe the README should mention that ansible_connection must be set in the inventory file for secret paths containing "connection" to work reliably.

[gbevan]

Hi @easybe you should be able to move the ansible_connection from your group_vars/all.yml to your inventory file, e.g.:

[all]
...
[all:vars]
ansible_connection=ssh
...

That should be applied prior to the hashivault_vars plugin.

[gbevan]

I think you can also create a group/all entry in vault with that setting, emulating the group_vars/all

[easybe]

I think you can also create a group/all entry in vault with that setting, emulating the group_vars/all

I would rather not do that. As I said, I would like to keep only secrets there.

Also, I would prefer to keep the the vars and the inventory separate.

[gbevan]

I could add support for an environment variable to change the behaviour, e.g.

HASHIVAULT_VARS_RESOLVE_CONNECTION=0

so, if set, it would prevent the resolving of ansible_connection in the plugin and use hosts/domains paths without the connection, like you suggest.

[easybe]

My proposal: #25
I'd be happy to get review/test feedback and update it accordingly.

[gbevan]

Cheers for that - i've taken what you did in #25 and extended to still support the original use-case and domains/fqdns, and added BATs tests for the travis tests. Please see PR #26

[gbevan]

#26 is merged. 0.2.0 is released to PyPI. thx