Coder Social home page Coder Social logo

Comments (2)

clayjohn avatar clayjohn commented on June 16, 2024 2

This comes down to a difference in how negative values are handled by vulkan and opengl given the respective framebuffer formats. Oh, and also the GPU drivers.

In OpenGL we write to a buffer that is explicitly in the 0-1 range. Some drivers will clamp negative values while others wraparound negative values.

We should probably just always clamp out the values to the 0-1 before writing them in the internal shader to avoid differences in drivers

from godot.

Zorochase avatar Zorochase commented on June 16, 2024

roc4u1000 on Godot Forum suggested this change to the code:

ALBEDO =
    clamp(albedo_color.rgb +
    brightness +
    darkness * vec3(-shadow_intensity), .0, 1.);

which fixed the issue with the shader, but we're still curious as to why this fixed it. It might still be an issue with Godot, so I'm leaving this open for now.

from godot.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.