Comments (7)
Bromeon
commented on May 30, 2024
Is rustfmt accessible on your system?
Does the issue already occur with Beta 9?
from gdext.
jabcross
commented on May 30, 2024
Is rustfmt accessible on your system?
Yes, version 1.5.1. I'm on Manjaro.
Does the issue already occur with Beta 9?
Just tested, yes, same error.
from gdext.
jabcross
commented on May 30, 2024
Found issue: it's trying to run rustup, but I installed rustfmt using cargo install. I don't have rustup installed.
I just changed the code in rustfmt_if_needed to call rustfmt directly instead of through rustup, and that seems to have worked.
from gdext.
Bromeon
commented on May 30, 2024
Ah, nice find! I think this issue also exists in gdnative.
Since you made the necessary changes already, would you be happy to submit a PR? (At the moment, it may take a bit longer until I can have a look though 😉)
from gdext.
jabcross
commented on May 30, 2024
Well, as long as rust-fmt also gets added to the path when installed through rustup, it should work. I'll do it when I get home.
from gdext.
jabcross
commented on May 30, 2024
Here you go. #59
from gdext.
Bromeon
commented on May 30, 2024
Closed by #59.
from gdext.
Related Issues (20)
- `#[derive(GodotClass)]` on tuple structs should fail before other macro failures HOT 4
- `Engine::register_singleton` corrupts object ref count HOT 3
- `GodotClass`: user vs. library items, characteristics and orthogonality
- Improvements with Godot classes for better templating HOT 3
- Make `ScriptInstance.call` and company re-entrant HOT 15
- ScriptLanguageExtension methods can be called from multiple threads HOT 2
- Support using `Base` for initialization in `init` function HOT 7
- Impl `Iterator::size_hint()` for `Dictionary` iterator types HOT 3
- Support every class-registration option that Godot offers HOT 1
- AutoLoaded scenes through an EditorPlugin GodotClass are not added the scene of the editor node tree HOT 7
- Module `convert_error` is private HOT 2
- GDExt panics when two structs from different modules are named the same HOT 1
- `Gd<Self>` return type causes type error when fn annotated with `#[func]` HOT 2
- Implement (or derive) GodotType for godot compatible repr enums HOT 2
- Godot editor crashes when hot reloading gdext library with custom resources HOT 6
- Import Godot docs for builtin types HOT 7
- No recommended way to call `Base<T>` methods from `init` HOT 2
- Single- and multi-threading support for `Callable::from_fn` HOT 1
- `gdext`-based custom resource format tools needs `experimental-threads` feature HOT 2
- Add the the ability to iterate over Godot enums HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from gdext.