Coder Social home page Coder Social logo

Comments (14)

Godiesc avatar Godiesc commented on June 16, 2024

hi,
you should read the patch notes of this new version of the theme, I said that "tab-shapes" config can't align the selected-tab background with the background behind; sadly this seems to be unsolvable.

from firefox-gx.

OleExploder avatar OleExploder commented on June 16, 2024

Ok, thank you.

from firefox-gx.

Godiesc avatar Godiesc commented on June 16, 2024

This bug will solve in the next release of the theme, I was able to solve it.

from firefox-gx.

OleExploder avatar OleExploder commented on June 16, 2024

That's cool, thank you!

from firefox-gx.

Godiesc avatar Godiesc commented on June 16, 2024

@OleExploder A new release of the theme was made, can you test it to see if all works fine?

from firefox-gx.

OleExploder avatar OleExploder commented on June 16, 2024

I am sorry for the late reply but I tested it and everything looks better from what I have seen. Btw, are the tabs supposed to be opaque unlike the address bar?
Screenshot 2024-01-10 184629

I also want to note that a similar issue still happens when dragging a tab as well.

from firefox-gx.

Godiesc avatar Godiesc commented on June 16, 2024

when "dragging a tab" is a unsolvable bug, but the theme should looks well in the selected tab, I notice some themes with images can't align the image, I don't know why. other themes looks right like this:
https://addons.mozilla.org/es/firefox/addon/geometric-fury/

from firefox-gx.

OleExploder avatar OleExploder commented on June 16, 2024

I see, thanks.

from firefox-gx.

Godiesc avatar Godiesc commented on June 16, 2024

I was working on solution and seems I find out, I added this code, you can added for now in ogx_tricks.css:

  :root:is([lwtheme-image]){
  --lwt-background-alignment: right top !important;
  }

This solution will be include in the next release of the theme.

from firefox-gx.

OleExploder avatar OleExploder commented on June 16, 2024

I tried adding that but nothing seemed to change and I could've done that wrong by using Notepad but I am not sure.

from firefox-gx.

Godiesc avatar Godiesc commented on June 16, 2024

All themes seems fine for me with that fix:

imagen

imagen

imagen

from firefox-gx.

OleExploder avatar OleExploder commented on June 16, 2024

Looking at it again, same thing actually using one of the themes you listed in your comment so I think it might've worked but some themes still actually have the tab itself in a different color compared to the address bar such as this theme and dragging the tab looks the same even with that fix but I think it would be hard to fix like you said.

from firefox-gx.

Godiesc avatar Godiesc commented on June 16, 2024

It seems that themes that use transparencies in its images will have that problem, that theme you share use a svg image that just put the lines on repeat but the blue color is not part of the image, is part of the --frame color, that is why the problem appear. That That will become a permanent issue, I will add that info to the page. Thanks for your report.

from firefox-gx.

OleExploder avatar OleExploder commented on June 16, 2024

You're welcome and thanks.

from firefox-gx.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.