Looking forward to your response about ws

[gobwas]

Hi @jeevatkm! Glad to hear about your plans. It is probably production ready – ws is used at mail.ru for a pretty long time without any issues. So I think we can tag it v1.0.0 soon. Could you try to integrate ws into aah – if there will no be any problems, I think I will tag it?

[zebox]

It's good news. I going to use this library for production too.

[gobwas]

Hi @jeevatkm!

Sorry for the delaying answers )

Just wondering, Is it possible send pipe stream upwards for read?

Yes, it is possible if you will use wsutil.Reader instead of super-higher level helpers =)

Not sure about write perspective, is it possible expose io.Writer option so that as I write to it, wsutil writes to client.

Yes, there is also wsutil.Writer for that purpose. But notice that it is like bufio.Writer – you must to Flush() it after writing a frame. It is also supports fragmentation.

Mainstream PR: go-aah/aah#172

Will take a look at this for possible usage and performance suggestions 👍

[jeevatkm]

@gobwas I'm sorry I forget to clearly mention, Please focus on https://github.com/go-aah/ws (godoc: https://godoc.org/aahframework.org/ws.v0) library and share your feedback. Ignore that pull request. That one is just lib integrate.

[gobwas]

Hi @jeevatkm!

Finally, I am started to moving things here =)
So, the first tag is v0.1.0 which contains current stable API.
Then, I've broken API via this commit 2c0cb1d to fix the issue #47.
And now, I have opened a pull request #50 (currently in work-in-progress state) where Im planning to collect last things I want to break before v1.0.

So this is the plans, let me know is something is wrong or confusing.

[jeevatkm]

@gobwas Sounds good. Let me integrate with aah, once done I will ping here. Would mind to take a look after that? provide your inputs for improvements.

[jeevatkm]

@gobwas Integration with aah framework progressing well.

I'm using ws.UpgradeHTTP way (to support same port for WebSocket and HTTP) and wsutil methods.

Just wondering, Is it possible send pipe stream upwards for read? Here https://github.com/gobwas/ws/blob/master/wsutil/helper.go#L233 wsutil reads all the bytes and returns to caller instead sending a bytes as you read.

Not sure about write perspective, is it possible expose io.Writer option so that as I write to it, wsutil writes to client.

[jeevatkm]

@gobwas Any suggestions welcome too, which I might have over looked library capabilities.

[jeevatkm]

@gobwas I have successfully integrated your WebSocket library into aah framework 🎉

Library: https://github.com/go-aah/ws
Mainstream PR: go-aah/aah#172

Gonna start working on documentation 😄

[jeevatkm]

@gobwas Thank you, I will give it a try on Reader & Writer.

[jeevatkm]

Also think about tag plan and please let me know.

[jeevatkm]

Thank you @gobwas. I'm glad to hear about first tag and looking forward to upcoming v1.0 release.

I looked at the PR #50, I understand your goal 👍.

PS: I will ping you in this thread, before I make a aah v0.11.0 release. Tentative plan is end of next month.

[jeevatkm]

@gobwas I'm gonna to release aah v0.11.0 coming Friday against gobwas/ws master branch. Do me a favor before merging #50 into master, please ping me. Thanks.

[jeevatkm]

@gobwas aah v0.11.0 released on Jul 06, 2018. Thank you.