Comments (14)
Hi @jeevatkm! Glad to hear about your plans. It is probably production ready – ws
is used at mail.ru for a pretty long time without any issues. So I think we can tag it v1.0.0
soon. Could you try to integrate ws
into aah
– if there will no be any problems, I think I will tag it?
from ws.
It's good news. I going to use this library for production too.
from ws.
Hi @jeevatkm!
Sorry for the delaying answers )
Just wondering, Is it possible send pipe stream upwards for read?
Yes, it is possible if you will use wsutil.Reader
instead of super-higher level helpers =)
Not sure about write perspective, is it possible expose io.Writer option so that as I write to it, wsutil writes to client.
Yes, there is also wsutil.Writer
for that purpose. But notice that it is like bufio.Writer
– you must to Flush()
it after writing a frame. It is also supports fragmentation.
Mainstream PR: go-aah/aah#172
Will take a look at this for possible usage and performance suggestions 👍
from ws.
@gobwas I'm sorry I forget to clearly mention, Please focus on https://github.com/go-aah/ws (godoc: https://godoc.org/aahframework.org/ws.v0) library and share your feedback. Ignore that pull request. That one is just lib integrate.
from ws.
Hi @jeevatkm!
Finally, I am started to moving things here =)
So, the first tag is v0.1.0
which contains current stable API.
Then, I've broken API via this commit 2c0cb1d to fix the issue #47.
And now, I have opened a pull request #50 (currently in work-in-progress state) where Im planning to collect last things I want to break before v1.0
.
So this is the plans, let me know is something is wrong or confusing.
from ws.
@gobwas Sounds good. Let me integrate with aah
, once done I will ping here. Would mind to take a look after that? provide your inputs for improvements.
from ws.
@gobwas Integration with aah framework progressing well.
I'm using ws.UpgradeHTTP
way (to support same port for WebSocket and HTTP) and wsutil
methods.
Just wondering, Is it possible send pipe stream upwards for read? Here https://github.com/gobwas/ws/blob/master/wsutil/helper.go#L233 wsutil reads all the bytes and returns to caller instead sending a bytes as you read.
Not sure about write perspective, is it possible expose io.Writer
option so that as I write to it, wsutil writes to client.
from ws.
@gobwas Any suggestions welcome too, which I might have over looked library capabilities.
from ws.
@gobwas I have successfully integrated your WebSocket library into aah framework 🎉
Library: https://github.com/go-aah/ws
Mainstream PR: go-aah/aah#172
Gonna start working on documentation 😄
from ws.
@gobwas Thank you, I will give it a try on Reader & Writer.
from ws.
Also think about tag
plan and please let me know.
from ws.
Thank you @gobwas. I'm glad to hear about first tag and looking forward to upcoming v1.0
release.
I looked at the PR #50, I understand your goal 👍.
PS: I will ping you in this thread, before I make a aah v0.11.0
release. Tentative plan is end of next month.
from ws.
@gobwas I'm gonna to release aah v0.11.0 coming Friday against gobwas/ws
master branch. Do me a favor before merging #50 into master, please ping me. Thanks.
from ws.
@gobwas aah v0.11.0 released on Jul 06, 2018. Thank you.
from ws.
Related Issues (20)
- Question: client example
- EOF error on ws.Upgrade HOT 8
- Is it necessary to use sync.Pool to reuse Reader Object in readData? HOT 1
- Read and Write timeouts? HOT 5
- Handshake.Extentions pointing to a buffer already returned to pbufio.ReaderPool
- State of the package and security updates HOT 6
- Websocket error on Safari HOT 4
- Dialer's Header parameter doesn't work as intended HOT 6
- Is WriteServerMessage thread-safe? HOT 9
- json decoder or unmarshaler? HOT 2
- Client-side example? HOT 5
- readme example problem HOT 1
- Correct way to handle continuation frame? HOT 1
- ReadFrame maxs out at 4096 lengths HOT 11
- RSV1 set, FIN not set on control using wsutil HOT 1
- Question - add headers during the upgrade HOT 2
- message rate limiter HOT 1
- Client disconnects on its own due to the 1008 error and EOF error. HOT 8
- Any example for using this library with `gnet`? HOT 5
- I encountered a problem of automatic disconnection after 30 seconds HOT 2
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from ws.