Comments (4)
The code generation algorithms do their best efforts to compute the set of needed packages. There seems to be a few missing here and I'll create a PR shortly to address them. The case of "too many" imports is harder to deal with (sometimes fmt
is needed sometimes it's not depending on how the types are defined in the DSL). There is logic that should detect whether it's needed though - looks like it's missing a case.
While the generator code strives to generate the right imports (and if it doesn't it's generally a bug like the cases above) the saving grace is the use of goimports
. Once the generator is done it invokes goimports
on the files which both fixes up the formatting and the import clauses. I'm guessing that's why nobody else has reported these issues. So TL;DR it looks like for some reason goimports
is not working properly here. Could you describe a little bit your Go setup? do you have multiple GOPATH? is goimports
installed and in the PATH?
from goa.
goimports was not installed. I've installed the package running
go get golang.org/x/tools/cmd/goimports
and now it's working.
Thanks for your time!
from goa.
Great, thanks for confirming. I'll still update the generators code so they add the missing imports explicitly.
from goa.
Added the missing imports and an explicit check for goimports
in goagen
so that this shouldn't happen anymore.
from goa.
Related Issues (20)
- Support OpenAPI V3 YAML/JSON oneof HOT 4
- can't set cookie 'SameSite' attribute HOT 2
- How to get the native *http.Request from the payload? HOT 2
- Missing schemas in OpenAPI spec when using union types HOT 3
- Declare POST request contain an array of object HOT 2
- Bumping goa.design/plugins/v3 from 3.14.0 to 3.14.1 is causing my client generation to fail HOT 3
- Generated code for nested inline attributes doesn't compile HOT 2
- Deprecated Code in Generated http.go using goa example
- meta for externalDocs and deprecated? HOT 4
- Map as Query Param not working? HOT 2
- Using Param() to map path parameters to attributes results in a runtime error HOT 5
- Panic in main HOT 2
- Goa panics when query params have unclosed square brackets HOT 2
- Goa panics when a user provides an explicit `null` where a `Map` is expected, if it's a nested structure HOT 2
- Middleware in design? HOT 6
- Goa generating uncompilable code while using views on types that contain OneOf union type
- Goa generating invalid code when OneOf types is a user defined type
- Example generation failed in the latest version HOT 3
- Generated server code parses query parameters repeatedly HOT 1
- Getting the Raw Query? HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from goa.