Coder Social home page Coder Social logo

Comments (6)

kolaente avatar kolaente commented on May 23, 2024 2

Mhh I think 1 is the one that would be the best solution between removing the logo and having a broken logo. Maybe we should just include this in the api though as that's what sends the mails. I'll take a look.

from vikunja.

kolaente avatar kolaente commented on May 23, 2024

Do you know if Gmail supports inline svgs? That way we could just inline the logo and wouldn't need to work around the ux-issues of a multi billion dollar company.

The logo is loaded from the frontend not from the api but the api handles everything email related. Including the logo in another format in the frontend would require a change there (even though a little) and I'd like to avoid shipping a png with every frontend build just to use it in an email.

from vikunja.

valantur avatar valantur commented on May 23, 2024

I did some research on this and it looks like inline svgs are also blocked.
I sent a test email from Vikunja to my work account hosted on Office 365 and the logo is blocked there too (on both the web version of Outlook and the Windows desktop client).

I haven't tested inline svgs though.

from vikunja.

CorneliousJD avatar CorneliousJD commented on May 23, 2024

I have a few ideas that might help.

  1. Although you want to avoid shipping a png just for this, that sounds like it would be the easiest solution and only add a few kb of space to the frontend. I would personally go this route if it was me.

  2. Allowed a user-uploaded image in their settings to be used for their e-mail notifications. Then they can upload whatever image or PNG they want. This would take more code for sure but each user could have their own customized image displayed.

  3. Allow users to set an env variable for "MAILER_LOGO_URL" that points to another URL of a file that they supply themselves. Lazy users could use imgur or something to host and link to a PNG they want to use.

  4. Host a emaillogo.png on https://vikunja.io/ that all the e-mails pull from. This will increase traffic on your server though from all users, including self-hosted that have e-mail reminders setup.

  5. Lastly, just remove the image from displaying on e-mails. Replace w/ just text, or remove that image block altogether? This would be the quickest/easiest way to avoid the broken image, but also the least exciting ;)

I hope one of these helps!
I would vote for option 1 or option 3, as those would seem easiest to implement and still result in the look/feel you were originally going for.

from vikunja.

kolaente avatar kolaente commented on May 23, 2024

Added in https://kolaente.dev/vikunja/api/pulls/1187 - please check with the next unstable release if it works as intended.

from vikunja.

dpschen avatar dpschen commented on May 23, 2024

Related: https://kolaente.dev/vikunja/api/issues/1478

from vikunja.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.