Comments (6)
Mhh I think 1 is the one that would be the best solution between removing the logo and having a broken logo. Maybe we should just include this in the api though as that's what sends the mails. I'll take a look.
from vikunja.
Do you know if Gmail supports inline svgs? That way we could just inline the logo and wouldn't need to work around the ux-issues of a multi billion dollar company.
The logo is loaded from the frontend not from the api but the api handles everything email related. Including the logo in another format in the frontend would require a change there (even though a little) and I'd like to avoid shipping a png with every frontend build just to use it in an email.
from vikunja.
I did some research on this and it looks like inline svgs are also blocked.
I sent a test email from Vikunja to my work account hosted on Office 365 and the logo is blocked there too (on both the web version of Outlook and the Windows desktop client).
I haven't tested inline svgs though.
from vikunja.
I have a few ideas that might help.
-
Although you want to avoid shipping a png just for this, that sounds like it would be the easiest solution and only add a few kb of space to the frontend. I would personally go this route if it was me.
-
Allowed a user-uploaded image in their settings to be used for their e-mail notifications. Then they can upload whatever image or PNG they want. This would take more code for sure but each user could have their own customized image displayed.
-
Allow users to set an env variable for "MAILER_LOGO_URL" that points to another URL of a file that they supply themselves. Lazy users could use imgur or something to host and link to a PNG they want to use.
-
Host a emaillogo.png on https://vikunja.io/ that all the e-mails pull from. This will increase traffic on your server though from all users, including self-hosted that have e-mail reminders setup.
-
Lastly, just remove the image from displaying on e-mails. Replace w/ just text, or remove that image block altogether? This would be the quickest/easiest way to avoid the broken image, but also the least exciting ;)
I hope one of these helps!
I would vote for option 1 or option 3, as those would seem easiest to implement and still result in the look/feel you were originally going for.
from vikunja.
Added in https://kolaente.dev/vikunja/api/pulls/1187 - please check with the next unstable release if it works as intended.
from vikunja.
Related: https://kolaente.dev/vikunja/api/issues/1478
from vikunja.
Related Issues (20)
- Opera Mobile OIDC Login not possible HOT 8
- Upcoming "Today" not showing expected tasks HOT 1
- Problems with single-container version: 502, Migration failed, no live upstreams HOT 1
- cannot scroll sidebar to switch to different list items HOT 2
- Line breaks not working in task description HOT 2
- Date picker current date incorrect if page was not refreshed in browser today HOT 3
- 403 Forbidden when adding Label in Share Link HOT 4
- Dark mode - Low contrast for table headers within tasks HOT 1
- Todoist migration: Buckets HOT 3
- Saved filters are not updated when tasks are updated HOT 4
- sticky openid login / Authentik OpenID misconfiguration HOT 4
- Switching back from :unstable tag to :latest tag breaks website HOT 3
- Kanban board width too small in share link HOT 1
- Error when paste text to task - error reading 'nodeSize' HOT 2
- Unable to go to cloud app in Brave Private tab. HOT 1
- Add cache-control headers to background images
- State in docs where to report bugs/issues
- patch to fix typos HOT 2
- Make import page have formatting consistent with other pages HOT 2
- Succesful login does not redirect/login HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from vikunja.