Comments (4)
I think serve that in backend is a good idea, and I like to avoid crapy JavaScript as much as possible.
Yeah, both ways can coexist, but on my mind, if I'm using the JS interface, I'd prefer everything to load that way. Helps making a PWA for mobile devices easier to develop too. But again, just random thoughts on my head.
In this particular case, since we open a new tab for article content, a "go back" equals to a "window.close()
".
from shiori.
@fmartingr somehow I agree. We can do both and user can be select between them in settings.
if you don't have a problem with that (make codebase bigger for this kind of setting) I can do that.
I think open in current tab is better option. User can be always open in new tab.
from shiori.
I just got used to the fact that the article opens in a new tab and just close it when I want to go back to the main Shiori interface. I keep thinking that maybe we should add the readable to the main javascript interface instead of serve that in the backend, but it's some discussion I want to have once I finish the new API (#497). I should sit down and elaborate a proper roadmap too.
from shiori.
I think serve that in backend is a good idea, and I like to avoid crapy JavaScript as much as possible.
Personally, I prefer to keep shiori keep fast as possible. I am tired of all heavy slow project out there.
About roadmap, I like that idea. I suggest review KOReader project. How it is good to organize, maybe you can find good point there.
from shiori.
Related Issues (20)
- Option to add existing URL as new bookmark HOT 7
- Can Shiori import firefox bookmarks json ? HOT 3
- "Edit bookmark" API docs do not mention required fields correctly
- [meta/discussion] Import/Export functionality HOT 16
- empty epub HOT 6
- Hierarchy / Folders HOT 2
- Logo font not load correctly HOT 5
- SHIORI_HTTP_SECRET_KEY HOT 5
- google/uuid instead of gofrs/uuid HOT 2
- 500 Internal Server Error when loading main image of bookmarked site
- Folder structure HOT 3
- Import bookmarks from Firefox and Chorme HOT 1
- Having Postgres Set up for Other Things Causes Non-Start of Shiori v1.6* with Sqlite. HOT 1
- Start page bug HOT 3
- Some checkbox of add bookmarks HOT 3
- security context is necessary for Kubernetes HOT 1
- Hashes on integrity attribute on archives are broken
- Batch features
- Abstract filesystem manipulation using afero
- Add s3 as storage option HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from shiori.