Comments (3)
Whomever lands checking this out, please also check that all archive and ebook data is properly handled on cleanup as well.
Relates to: #634
from shiori.
Are you sure we should update ebook with archive update (without user request) too?
So if an article has ebook before update, it should generate each time with update archive?
from shiori.
Are you sure we should update ebook with archive update (without user request) too? So if an article has ebook before update, it should generate each time with update archive?
No, not meaning that. But when this issue is checked we should apply the same logic for archives, thumbs and ebooks:
- Download the appropriate asset
- Success? -> Remove old asset and replace with new one.
- Failure? -> Do not remove old asset and present error to the user. #634
from shiori.
Related Issues (20)
- 500 Internal Server Error when loading main image of bookmarked site
- Folder structure HOT 2
- Import bookmarks from Firefox and Chorme HOT 1
- Having Postgres Set up for Other Things Causes Non-Start of Shiori v1.6* with Sqlite. HOT 1
- Start page bug HOT 3
- Some checkbox of add bookmarks HOT 3
- security context is necessary for Kubernetes HOT 1
- Hashes on integrity attribute on archives are broken
- Batch features
- Abstract filesystem manipulation using afero
- Add s3 as storage option HOT 1
- New Android Client App for go-shiori/shiori HOT 10
- Title not automatically set after adding url HOT 1
- Implementing Cache Update Feature in Android Client HOT 1
- Route /api/login not available HOT 8
- No web interface on Shiori 1.6.0 RC 6 HOT 6
- Image Caching Issue When Re-creating Bookmarks HOT 2
- shiori print command or API doesn't return the thumbnail url
- Hard to find default Login and Password HOT 1
- Can't Access swagger/index.html HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from shiori.