Comments (4)
I think what's going on here is with binary replication the 'bits' are meant to be transferred and applied, as signed/unsigned have the same bit pattern, no problem. What the library is doing is being helpful returning int64 for all integral types to reduce the number of type cases to handle. Where this goes off is widening an 8, 16, 24, or 32 signed value.
e.g. return int64(binary.LittleEndian.Uint32(data))
will return values like 4294967295 for -1.
I tested some changes in a fork to always sign-extend while widening (even for the INT24 case to int32 then int64). This worked much better.
I continued on to then return the various int8 thru int64 interface{} types meaning the user will need to expect these. The advantage is that there's no possibility of data mangling (-1 -> 4294967295) and if you want the unsigned version a cast will convert.
I'll see about making a Pull Request to see this. My branch has import package renaming (not yet using Go 1.5 vendor'ing feature) that needs to be tidied before I do so.
Note: There might be a similar issue with date handling for (negative) dates before Jan. 1, 1970, but I didn't really look into that.
from go-mysql.
Can we close it now?
from go-mysql.
Thanks for accepting PR#27, we can close the PR. Please also consider PR#28 as well before closing the issue.
The follow-up PR #28 returns smaller (and unsigned) integer or float32 types for interface{}. There's notes there for pros/cons. I think the upside is greater with a slight non-backward compatibility (users have to also handle int8, uint8, float32, etc in addition to int64 and float64).
from go-mysql.
Thanks, I will close it and move another. :-)
from go-mysql.
Related Issues (20)
- Is it possible to use github.com/klauspost/compress instead of github.com/DataDog/zstd HOT 5
- TableMapEvent 中 ColumnName 获取列名称是空数据。mysql是5.7版本 HOT 6
- Can we only focus the data changes of the tables we care about? HOT 1
- 关于Canal的binlog事件重试疑问 HOT 1
- 什么情况下event.Rows长度会为0 或者为nil? HOT 1
- When will the length of event.Rows be 0 or nil? HOT 4
- invalid sequence 0 != 1 HOT 6
- canal.RowsEvent returns 2 duplicate rows for every update event HOT 2
- Proper way to save position after Canal OnRow event HOT 3
- canal处理Text类型字段时增量日志和存量日志对应的数据结构不同 HOT 1
- add value string output HOT 5
- add a EventCacheSize variable to BinlogSyncerConfig to limit the streamer's memory usage
- How to start binlog syncer from last position HOT 3
- Tables
- Why In OnRow e.Header is nil ,no e.Header.LogPos
- canal can't send create index and drop index sql HOT 2
- MySQL 8.3 will introduce new GTID format
- [Warning] Aborted connection 52412 to db: 'unconnected' user: 'boss' host: '' (Got an error reading communication packets) HOT 7
- how to remove log output HOT 2
- column values missing
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from go-mysql.