Comments (4)
can I entrust you with completing this task?
Yes, but, I need to explore how add protovalidate
in the core and if it's complicated or not :
- PGV generate Go/Java/C++/... code to verify inputs,
- protovalidate is based on CEL (Common Expression Language), no code is generated and use his runtime : bufbuild/protovalidate#47 (comment)
from kratos.
🤖
Hello @perriea,
Nice to meet you! I'm Dosu, a bot here to assist you with bugs, answer your questions, and guide you on your journey to becoming a contributor. While we wait for a human maintainer to join us, feel free to ask me anything about the Kratos repository. I'm here to help!
It seems like you've got this under control, if you want help or have specific questions, let me know what I can do for you!
from kratos.
SGTM, can I entrust you with completing this task?
from kratos.
Finaly, It's simple (after one call HTTP) :
2023-11-13T23:57:00.408+0100 [ERROR] app: args="filters:{values:\"1\"} sort:{argument:Ticker} pagination:{items:1 page:-1}" caller=recovery/recovery.go:59 code=400 component=http kind=server latency=0.001073208 operation=/instruments.v1.Instruments/Search reason=VALIDATOR
stack=
| error: code = 400 reason = VALIDATOR message = validation error:
| - pagination.page: value must be greater than or equal to 1 [int32.gte] metadata = map[] cause = validation error:
| - pagination.page: value must be greater than or equal to 1 [int32.gte]
- On tests, obviously, it's a fail, I don't know how to repair because now, it's not a classic
struct
but aprotoreflect.ProtoMessage
, protovalidate-go
requiregoogle.golang.org/grpc v1.57.0
, todaygoogle.golang.org/grpc v1.56.1
(shared dependencies between all packages),- I will do more tests tomorrow.
from kratos.
Related Issues (20)
- [Feature] allow custom signal to do some handle logic HOT 1
- [Question] When using http, if I want to set timeouts for different routes, how should I set them? HOT 2
- [Feature] Some specification issues when Kratos registers services on Polaris HOT 9
- I have a question about proto. HOT 2
- apollo settings Watch cannot hot update configuration normally
- http.NewClient results in NODE_NOT_FOUND
- load apollo config yml format panic HOT 5
- [Question] 如何使用json.Marshal 作为http server 返回的序列化工具 HOT 2
- [Question] The middleware is Executed at the end of the request? HOT 7
- [Question] trace.id is not passed HOT 5
- [Question] How to limit HTTP request size? HOT 6
- The trace_id between requests is getting mixed up HOT 4
- [Question] How should I create a kratos project HOT 1
- net: lookupIPAddr dns resolving panic by data race. HOT 4
- [Question] The pprof profile is not valid HOT 4
- [Question] Pubsub Implementation HOT 3
- [Question]How to print trace.id in log log HOT 8
- Request context canceled during graceful shutdown HOT 3
- [Question]How to do unit testing? HOT 5
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from kratos.