Coder Social home page Coder Social logo

Comments (4)

perriea avatar perriea commented on July 20, 2024 1

can I entrust you with completing this task?

Yes, but, I need to explore how add protovalidate in the core and if it's complicated or not :

  • PGV generate Go/Java/C++/... code to verify inputs,
  • protovalidate is based on CEL (Common Expression Language), no code is generated and use his runtime : bufbuild/protovalidate#47 (comment)

from kratos.

dosubot avatar dosubot commented on July 20, 2024

🤖

Hello @perriea,

Nice to meet you! I'm Dosu, a bot here to assist you with bugs, answer your questions, and guide you on your journey to becoming a contributor. While we wait for a human maintainer to join us, feel free to ask me anything about the Kratos repository. I'm here to help!

It seems like you've got this under control, if you want help or have specific questions, let me know what I can do for you!

from kratos.

shenqidebaozi avatar shenqidebaozi commented on July 20, 2024

SGTM, can I entrust you with completing this task?

from kratos.

perriea avatar perriea commented on July 20, 2024

Finaly, It's simple (after one call HTTP) :

2023-11-13T23:57:00.408+0100 [ERROR] app: args="filters:{values:\"1\"}  sort:{argument:Ticker}  pagination:{items:1  page:-1}" caller=recovery/recovery.go:59 code=400 component=http kind=server latency=0.001073208 operation=/instruments.v1.Instruments/Search reason=VALIDATOR
  stack=
  | error: code = 400 reason = VALIDATOR message = validation error:
  |  - pagination.page: value must be greater than or equal to 1 [int32.gte] metadata = map[] cause = validation error:
  |  - pagination.page: value must be greater than or equal to 1 [int32.gte]
  • On tests, obviously, it's a fail, I don't know how to repair because now, it's not a classic struct but a protoreflect.ProtoMessage,
  • protovalidate-go require google.golang.org/grpc v1.57.0, today google.golang.org/grpc v1.56.1 (shared dependencies between all packages),
  • I will do more tests tomorrow.

from kratos.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.