Coder Social home page Coder Social logo

Comments (3)

kniren avatar kniren commented on June 2, 2024

Hi @tobgu this makes complete sense. Reading from a Reader should be the preferred way of dealing with this.

In addition to this, it would also make sense that the Save methods would write to a Writer or WriteCloser for consistency and better composability.

The exception to this would be the ReadRecords/SaveRecords methods, but for other formats (CSV, JSON, XML...) it should work.

from gota.

tobgu avatar tobgu commented on June 2, 2024

Sounds good!

from gota.

kniren avatar kniren commented on June 2, 2024

I've finished with these modifications on the dev branch as of commit 48ef419

As a summary:

  • ReadCSV now accepts an io.Reader instead of a string
  • SaveCSV/SaveJSON now write directly to the given io.Writer instead of returning a []byte
  • SaveRecords/SaveMaps has been renamed to Records/Maps respectively to be consistent with the Dense method
  • ReadCSV/ReadMaps has been renamed to LoadCSV/LoadMaps since they don't accept readers.
  • SaveCSV/SaveMaps has been renamed to WriteCSV/WriteMaps for consistency with the Read* methods.
  • SaveMaps was not working properly and thus it has been fixed.

from gota.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.