support 3.8 about quart-github-webhook

[binary1230]

thanks for the lib and the homework

I submitted a PR with the code changes above and updated example. This issue should probably be renamed to be more about upgrading Flask/Quart versions and not about python 3.8, for clarity sake for others looking for breadcrumbs when they're first getting started if they hit the same issue we did.

Thanks!

[AstraLuma]

It should? I'm using this in https://github.com/ppb/binny/ with 3.9

[NargiT]

hum... I tried to build the project with only py38 and I have errors running tests. more over the build on the ci is broken so I don't understand why it fails.

[NargiT]

here is the error I got from pytest

self = <quart_github_webhook.webhook.Webhook object at 0x7f1b4e016820>
app = <Quart 'tests.test_webhook'>, endpoint = '/postreceive', secret = None

    def __init__(self, app, endpoint="/postreceive", secret=None):
>       app.add_url_rule(
            path=endpoint, endpoint=endpoint, view_func=self._postreceive, methods=["POST"],
        )
E       TypeError: add_url_rule() got an unexpected keyword argument 'path'

../quart_github_webhook/webhook.py:19: TypeError

[NargiT]

so I dig a bit and looks like since version 0.12.0 quart updated the api to match the one from flask.
pgjones/quart@7b1f6f2 and since no version is mentioned in tox.ini the build is not reproductible.

there is also another modification since 0.15.0 in quart pgjones/quart@4da1b58 that remove internal alias for werkzeug htts status.

So I don't know what to do, it's not an issue with the code more an issue with dependencies.

If I want to use latest version of quart, we have to update this.

@@ -17,7 +17,7 @@ class Webhook(object):
 
     def __init__(self, app, endpoint="/postreceive", secret=None):
         app.add_url_rule(
-            path=endpoint, endpoint=endpoint, view_func=self._postreceive, methods=["POST"],
+            rule=endpoint, endpoint=endpoint, view_func=self._postreceive, methods=["POST"],
         )
 
         self._hooks = collections.defaultdict(list)

[NargiT]

It should? I'm using this in https://github.com/ppb/binny/ with 3.9

and indeed it work in your project because it uses 0.11.5 https://github.com/ppb/binny/blob/5dea0551a310c5d105c59d1e730722a49e979e8f/poetry.lock#L641

[AstraLuma]

Ah, ok.

[AstraLuma]

I'll probably get to this Eventually:tm:, or I'll happily accept PRs.

[NargiT]

I can do the PR, not today. I might not be able to run all env in my local machine so I will try first on your CI.