Think about proper question template about zodiac-module-reality

[auryn-macmillan]

SafeSnap Proposal Acceptance Criteria [template]

In order for {organisation}'s SafeSnap module to execute a transaction, a corresponding proposal must have passed, as reported by Reality.eth.

The Reality.eth question should conform to this template (the required template ID is defined by the installed SafeSnap Module):

{"title": "Did the Snapshot proposal with the id {IPFS hash} pass the execution of the array of Module transactions that have the hash {0x prefixed keccak hash} and does the proposal conform to the {organisation}’s Proposal Acceptance Criteria listed at {IPFS hash}?", "lang": "en", "type": "bool"}

Reality.eth should resolve the question to “yes” only for proposals that:

• were initiated as a Snapshot proposal in the {organisation} space.
• had a minimum quorum of 4% of the circulating supply of {designated ERC20 token} having cast votes to approve execution of the transaction.
• had a voting period of at least 7 days.
• had no significant service outages or availability issues that could have reasonably restricted {designated ERC20 token} holders from casting their votes in the proposal.
• have a minimum bond on the Reality question that is equal to or greater than the minimum bond defined in the {organisation}’s installed SafeSnap module.
• the module transaction hash in the Reality.eth question is the keccak hash of the concatenation of the individual EIP-712 hashes of the module transactions defined in the Snapshot proposal.
  the plain description of the transactions, and their intended result, in the proposal is complete and accurate.
  do not occur during, in, or as a result of any unauthorized or malicious changes to the {organisation} Snapshot space.
• were not filtered from the default view in the {organisation} Snapshot space during the voting period.

Reality.eth should resolve the question to “invalid” if:

• the Reality.eth question meets the above requirements but was created prior to the end of the proposal vote period and/or the snapshot block for the vote.
  i.e. the final results of the vote are not yet known.

In all other cases, the Reality.eth question should be resolved to “no”.

[rmeissner]

Notes:

• The id {IPFS hash} and the EIP-712 tx hash {0x prefixed keccak hash} are on-chain template properties
• The Proposal Acceptance Criteria {IPFS hash} and {organisation} will be filled in on template creation (as they do not change with every question)

Is this correct?

TODO for myself: Add details on EIP-712 hashing

[auryn-macmillan]

Is this correct?

Yes, that sounds correct to me.