`add` and `edit` commands error if $EDITOR set to "vim -u ~/my-vimrc" about kb

[gnebbia]

Thanks for the suggestion!

Fixed with commit 699ba35

[tddschn]

Thanks for the quick fix!

I'm not familiar with setup.py and couldn't figure out how to upgrade kb, can you help me?

Here's what I tried:

git pull origin master # checked, add.py and edit.py fixed with "shell=True" added to call()
python setup.py install
python setup.py install --force

and it seems that these 2 commands still don't work.

[gnebbia]

do this:
within the kb direectory, execute:

pip install --upgrade .  # there is a dot after upgrade ;)

Let me know if it works!

[tddschn]

Thanks! :)

After upgrading kb with pip install --upgrade ., add works but edit doesn't.

I'll open a PR and try to fix it :)

[gnebbia]

Ok, fixed again, sorry, my bad, I did not update the edit module!
Thanks for warning me!
Can you update and tell me if it is solved now?

[tddschn]

Yes, thanks! :)

[gnebbia]

Ok I fixed it again and removed shell=True, since it may cause security issues through command injection.
Try to see if it works now, I tested and seems ok now!

[tddschn]

Yes it works! Thank you :)

[gnebbia]

You are welcome! Happy to be helpful!