Coder Social home page Coder Social logo

Comments (10)

gmoledina avatar gmoledina commented on June 17, 2024

Not anymore! I saw it a few days ago but looks perfect now. Do you still see it ?

from gmgridview.

steipete avatar steipete commented on June 17, 2024

It was there yesterday. Will check again. The Simulator is not perfectly framebuffer-synced. Thus, if you maybe add a view and change it's frame one loop later, you get flickering in the simulator, but it looks perfect on the device.

from gmgridview.

dxclancy avatar dxclancy commented on June 17, 2024

i see what may look like rogue cells popping visible and then invisible very quickly. I don't know if this is inherent in the core code or in my layout strategy, but it sounds like it may be similar to what you mention. i'll update if i have more info.

from gmgridview.

aquarius avatar aquarius commented on June 17, 2024

I saw the same problem. I was able to track it down to the UIViewAnimation part in -newItemSubViewForPosition:. However as steipete mentioned, the problem only appears in the simulator. Works fine for me on the device.

from gmgridview.

steipete avatar steipete commented on June 17, 2024

There is more to this. As the device has a better view sync, you usually don't see the flickering; but it's still visible some times. We should fix the root problem on this, it's ugly.

from gmgridview.

soleares avatar soleares commented on June 17, 2024

I'm seeing a glitch in the simulator only when I call -reloadData. This looks like it's caused by one of the latest commits "Put back an animation block to fix a glitch" in -newItemSubViewForPosition. When I revert this change I don't see the issue anymore.

from gmgridview.

soleares avatar soleares commented on June 17, 2024

I think the issue is due to the following in -newItemSubViewForPosition:

// To make sure the frame is not animated
[UIView animateWithDuration:0 
                      delay:0 
                    options:UIViewAnimationOptionOverrideInheritedDuration 
                 animations:^{
                     cell.frame = frame;
                     cell.contentView.frame = cell.bounds;
                 } 
                 completion:nil];

If I replace it with the following I don't see the issue anymore:

[CATransaction begin];
[CATransaction setValue:(id)kCFBooleanTrue
                 forKey:kCATransactionDisableActions];
cell.frame = frame;
cell.contentView.frame = cell.bounds;
[CATransaction commit];

from gmgridview.

steipete avatar steipete commented on June 17, 2024

soleares, thank you, this is very clever!

Will try it and replace the 0-delay blocks with this; i'm sure this also improves performance.

from gmgridview.

steipete avatar steipete commented on June 17, 2024

Works like a charm --> 22ec389

from gmgridview.

gmoledina avatar gmoledina commented on June 17, 2024

Great !!

from gmgridview.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.