Return item about databases

[mikegfink]

But what if you want to return it before it’s delivered? Just get a refund... then we save on the shipping. I think we don’t do that check because you then can’t change your mind and get your refund right away.

From: thpierce [mailto:[email protected]]
Sent: November-25-14 8:08 PM
To: gminaker/databases
Subject: [databases] Return if no delivery (#20)

We shouldn't be able to return stuff with no delivery date, right? I feel like we currently can, and should check this!

—
Reply to this email directly or view it on GitHub #20 .Image removed by sender.

[thpierce]

Ok fair, but then we should probably delete that thing from process deliveries

[mikegfink]

I don’t know what’s in process delivery. Haven’t worked on that file.

[thpierce]

I guess what I mean is more general: if everything is returned, this purchase should not exist anymore. There was no purchase, so no need to process in other things, such as process delivery, top selling items, etc.

[mikegfink]

I disagree, just because something gets returned doesn’t mean you remove the record of it. Once a transaction has happened you don’t want to edit it. We still want to know that something was purchased even if all are returned.

[anniechen92]

Tried returning 1 from receipt 3926

Warning: array_push() expects parameter 1 to be array, null given in C:\Users\Annie\databases\views\clerk\process_refund.php on line 155

If I try returning it again:
1 of UPC, 616402673105, have/has already been returned on this receipt.

Warning: array_push() expects parameter 1 to be array, null given in C:\Users\Annie\databases\views\clerk\process_refund.php on line 150

[mikegfink]

@anniechen92 try it now, pushed to master with change. It was an error checking scope thing.

[thpierce]

Doesn't update stock

[thpierce]

Fixed